Closed
Bug 1299863
Opened 8 years ago
Closed 7 years ago
Stop building two copies of gtest
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Unassigned)
References
Details
We currently build two copies of gtest with every build.
One that we use in the xul-gtest library:
https://dxr.mozilla.org/mozilla-central/rev/b7f7ae14590aced450bb0b0469dfb38edd2c0ace/testing/gtest/moz.build
and one that we use for WebRTC signalling tests:
https://dxr.mozilla.org/mozilla-central/rev/b7f7ae14590aced450bb0b0469dfb38edd2c0ace/media/webrtc/trunk/testing/gtest.gyp
via https://dxr.mozilla.org/mozilla-central/rev/b7f7ae14590aced450bb0b0469dfb38edd2c0ace/media/webrtc/moz.build#98
This is pretty silly. I tried the obvious fix, making the signalling tests link the gtest from testing/gtest, but that copy of gtest links in some mozilla-specific files so the signalling tests fail to link:
https://dxr.mozilla.org/mozilla-central/rev/b7f7ae14590aced450bb0b0469dfb38edd2c0ace/testing/gtest/moz.build#63
We could probably fix that by splitting that library into two libraries, like 'gtest' for the plain gtest bits and 'mozgtest' for the other stuff.
Alternately if we fixed bug 1257713 we just wouldn't need the webrtc copy of gtest.
Comment 1•7 years ago
|
||
This should be fixed by Bug 1316611 for the signaling gtest case and Bug 1343557 for the webrtc.org gtest case.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•