Closed Bug 1299864 Opened 8 years ago Closed 8 years ago

Target i586-unknown-linux-gnu when building rust code for linux32

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 wontfix, firefox49 fixed, firefox50 fixed, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox48 --- wontfix
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files, 1 obsolete file)

Target i586 with rust 1.10 on Firefox 50
(deleted), patch
glandium
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Target i586 with rust 1.11 on Firefox 51
(deleted), patch
glandium
: review+
Details | Diff | Splinter Review
Revert the requirement for SSE2 support in official 32-bit linux builds until we have a better migration story.
Assignee: nobody → giles
Blocks: 1291650
Comment on attachment 8787289 [details] Bug 1299864 - Target i585 linux when building rust code. https://reviewboard.mozilla.org/r/76102/#review74916 ::: browser/config/tooltool-manifests/linux32/releng.manifest:19 (Diff revision 1) > "filename": "gtk3.tar.xz", > "setup": "setup.sh", > "unpack": true > }, > { > -"version": "gecko rustc 1.10.0 (cfcb716cf 2016-07-03)", > +"version": "gecko rustc 1.11.0 (9b21dcd6a 2016-08-15) x86_64+i585", typo You shouldn't tie this with a rustc upgrade. Either upgrade first then switch the target, or the other way around, but please don't do both at the same time.
Attachment #8787289 - Flags: review?(mh+mozilla)
Ok, I'll do the update first.
No longer blocks: 1296403
Depends on: 1296403
Comment on attachment 8787289 [details] Bug 1299864 - Target i585 linux when building rust code. I seem to have confused review board. There's one patch for changing the target on rust 1.11 for Firefox 51, another for changing it on rust 1.10 for Firefox 50. I'll upload the old-fashioned way.
Attachment #8787289 - Attachment is obsolete: true
Attachment #8787289 - Flags: review?(mh+mozilla)
Attachment #8788630 - Flags: review?(mh+mozilla)
Attachment #8788632 - Flags: review?(mh+mozilla)
Comment on attachment 8788630 [details] [diff] [review] Target i586 with rust 1.10 on Firefox 50 Approval Request Comment [Feature/regressing bug #]: 1291650 [User impact if declined]: Linux users on systems without SSE2 support will experience crashes playing video. [Describe test coverage new/current, TreeHerder]: Build option change, should have no other effects. [Risks and why]: We're trying a new toolchain configuration which could have side effects. I believe that's unlikely; we've never had trouble with a rustc updates. In the event of an issue we can revert and accept the handful of crashes, or disable the optional code causing the issue like we did in Firefox 49. [String/UUID change made/needed]: None.
Attachment #8788630 - Flags: approval-mozilla-aurora?
Comment on attachment 8788630 [details] [diff] [review] Target i586 with rust 1.10 on Firefox 50 Review of attachment 8788630 [details] [diff] [review]: ----------------------------------------------------------------- At some point, the creation of the rustc packages will have to be in-tree and happen on taskcluster.
Comment on attachment 8788630 [details] [diff] [review] Target i586 with rust 1.10 on Firefox 50 Review of attachment 8788630 [details] [diff] [review]: ----------------------------------------------------------------- At some point, the creation of the rustc packages will have to be in-tree and happen on taskcluster.
Attachment #8788630 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8788632 [details] [diff] [review] Target i586 with rust 1.11 on Firefox 51 Review of attachment 8788632 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/config/tooltool-manifests/linux32/releng.manifest @@ +16,5 @@ > "unpack": true > }, > { > +"version": "gecko rustc 1.11.0 (9b21dcd6a 2016-08-15) x86_64+i586", > +"size": 99378568, interesting that it's 30M smaller.
Attachment #8788632 - Flags: review?(mh+mozilla) → review+
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f89db30c48bf Target i585 linux when building rust code. r=glandium
https://hg.mozilla.org/mozilla-central/rev/f89db30c48bf
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8788630 [details] [diff] [review] Target i586 with rust 1.10 on Firefox 50 Makes sense, Aurora50+
Attachment #8788630 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1319332
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: