Closed
Bug 1299891
Opened 8 years ago
Closed 8 years ago
Mark pageAction panels as tab-specific
Categories
(WebExtensions :: Frontend, defect, P1)
WebExtensions
Frontend
Tracking
(firefox51 verified, firefox52 verified)
VERIFIED
FIXED
mozilla52
People
(Reporter: kmag, Assigned: kmag)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
jaws
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
so that they close when the tab changes.
Updated•8 years ago
|
Priority: -- → P1
Whiteboard: triaged
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8796684 [details]
Bug 1299891: Make pageAction panels tab-specific.
https://reviewboard.mozilla.org/r/82442/#review82518
Attachment #8796684 -
Flags: review?(jaws) → review+
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a2a991b97a8
Make pageAction panels tab-specific. r=jaws
Comment 4•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 6•8 years ago
|
||
Mark 51 as fix-optional. If it's worth uplifting to 51, feel free to nominate it.
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8796684 [details]
Bug 1299891: Make pageAction panels tab-specific.
Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Prior to this change, tab-specific panels often stayed open after switching away from the tab that they apply to. This causes some confusion, and has been reported multiple times.
[Describe test coverage new/current, TreeHerder]: The behavior of these panels is thoroughly tested, and this patch adds additional tests for the new behavior.
[Risks and why]: Very low. This is a one-line change which adds a single attribute to a <panel> element. The panels already auto-close in this manner when they lose focus. This change just extends the behavior to a related circumstance.
[String/UUID change made/needed]: None.
Attachment #8796684 -
Flags: approval-mozilla-aurora?
Comment 8•8 years ago
|
||
Hi :kmag,
What is the feature or regressing bug of this issue?
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 9•8 years ago
|
||
Tab-specific panels were implemented in bug 1171746
Flags: needinfo?(kmaglione+bmo)
Comment 10•8 years ago
|
||
Comment on attachment 8796684 [details]
Bug 1299891: Make pageAction panels tab-specific.
Enhance user behaviors. Take it in 51 aurora.
Attachment #8796684 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•8 years ago
|
||
bugherder uplift |
Comment 12•8 years ago
|
||
I was able to reproduce the initial issue on Firefox 49.0.1 under Windows 10 64-bit.
Verified fixed on Firefox 52.0a1 (2016-10-19) and Firefox 51.0a2 (2016-10-19) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. PageAction panel is successfully closed while:
- opening a new tab (CTRL/CMD+T)
- switching between tabs (CTRL+TAB)
- closing a tab (CTRL/CMD+W)
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•