Closed Bug 1299891 Opened 8 years ago Closed 8 years ago

Mark pageAction panels as tab-specific

Categories

(WebExtensions :: Frontend, defect, P1)

defect

Tracking

(firefox51 verified, firefox52 verified)

VERIFIED FIXED
mozilla52
Tracking Status
firefox51 --- verified
firefox52 --- verified

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: triaged)

Attachments

(1 file)

so that they close when the tab changes.
Priority: -- → P1
Whiteboard: triaged
Attachment #8796684 - Flags: review?(jaws) → review+
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4a2a991b97a8 Make pageAction panels tab-specific. r=jaws
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Mark 51 as fix-optional. If it's worth uplifting to 51, feel free to nominate it.
Comment on attachment 8796684 [details] Bug 1299891: Make pageAction panels tab-specific. Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Prior to this change, tab-specific panels often stayed open after switching away from the tab that they apply to. This causes some confusion, and has been reported multiple times. [Describe test coverage new/current, TreeHerder]: The behavior of these panels is thoroughly tested, and this patch adds additional tests for the new behavior. [Risks and why]: Very low. This is a one-line change which adds a single attribute to a <panel> element. The panels already auto-close in this manner when they lose focus. This change just extends the behavior to a related circumstance. [String/UUID change made/needed]: None.
Attachment #8796684 - Flags: approval-mozilla-aurora?
Hi :kmag, What is the feature or regressing bug of this issue?
Flags: needinfo?(kmaglione+bmo)
Tab-specific panels were implemented in bug 1171746
Flags: needinfo?(kmaglione+bmo)
Comment on attachment 8796684 [details] Bug 1299891: Make pageAction panels tab-specific. Enhance user behaviors. Take it in 51 aurora.
Attachment #8796684 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I was able to reproduce the initial issue on Firefox 49.0.1 under Windows 10 64-bit. Verified fixed on Firefox 52.0a1 (2016-10-19) and Firefox 51.0a2 (2016-10-19) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. PageAction panel is successfully closed while: - opening a new tab (CTRL/CMD+T) - switching between tabs (CTRL+TAB) - closing a tab (CTRL/CMD+W)
Status: RESOLVED → VERIFIED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: