Closed
Bug 1300111
Opened 8 years ago
Closed 8 years ago
Remove 'X days ago' concise strings from TimeConstants
Categories
(Firefox for iOS :: General, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.4
People
(Reporter: sleroux, Assigned: bmunar)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
Due to issues with localization, we won't be able to properly translate the many plural form issues that come with localizing these kinds of string [1]. Instead of using these plural forms, let's use the existing strings and revert the `isConcise` changes to TimeConstants.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1181777
|
||
Updated•8 years ago
|
Priority: P3 → P2
|
||
Comment 1•8 years ago
|
||
How about we use a third party library instead? https://github.com/kevinlawler/NSDate-TimeAgo
does exactly what we want and is already localized in 33 languages. Does this support all the languages we need? If not maybe we could send a PR to add support for the missing languages?
Flags: needinfo?(splewako)
|
Reporter | |
Comment 2•8 years ago
|
||
> How about we use a third party library instead? https://github.com/kevinlawler/NSDate-TimeAgo
I think this is a great idea. I can see us forking this repo, maybe adding Carthage compatibility, and add the missing locales there then PR the changes back.
|
|
Reporter | |
Comment 3•8 years ago
|
||
Also it looks like that library has been folded into DateTools (https://github.com/MatthewYork/DateTools)
|
||
Comment 4•8 years ago
|
||
(In reply to Farhan Patel from comment #1)
> How about we use a third party library instead?
> https://github.com/kevinlawler/NSDate-TimeAgo
> does exactly what we want and is already localized in 33 languages. Does
> this support all the languages we need? If not maybe we could send a PR to
> add support for the missing languages?
It could be complicated (Flod could probably say more about this) and right now, with this library as is, it would be even worse than the current state for Polish (unacceptable really) even with bug 1289590 problematic patch applied.
Flags: needinfo?(splewako) → needinfo?(francesco.lodolo)
|
||
Comment 5•8 years ago
|
||
Not the mobile owner (that would be Delphine), but I personally would not depend on translations made by external entities.
Flags: needinfo?(francesco.lodolo)
|
|
||
Updated•8 years ago
|
Assignee: nobody → bmunar
|
|
||
Updated•8 years ago
|
Priority: P2 → P1
|
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 6•8 years ago
|
||
Ok, I will revert the changes back!
|
|
Assignee | |
Comment 7•8 years ago
|
||
Attachment #8788602 -
Flags: review?(sleroux)
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8788602 -
Flags: review?(sleroux) → review+
|
|
Reporter | |
Comment 8•8 years ago
|
||
master https://github.com/mozilla/firefox-ios/commit/b25b9ccee45cdbcdcd89079b1eea125088633243
Let's use https://bugzilla.mozilla.org/show_bug.cgi?id=1181777 to discuss alternatives such as using a third party library moving forward.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
||
Updated•8 years ago
|
Iteration: --- → 1.4
You need to log in
before you can comment on or make changes to this bug.
Description
•