Bug 966552 comes back again :( Steps To Reproduce: 1. Open data:text/html,<textarea> or http://www-archive.mozilla.org/editor/midasdemo/ 2. Type something 3. Ctrl + backspace Actual Results: Nothing happens Expected Results: The word just before caret should be deleted Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6795225dc65f98d2c5007e1bf8e0b7ffb2265e38&tochange=0770506cb101cb2a70d0e4d267361767a9bfc9b6 Regressed by: Bug 1293505

Wow, I'm surprised at not testing this with automated tests. I take this.

Comment on attachment 8788283 [details] Bug 1300319 part.0 Add automated tests for Ctrl+Backspace, Alt+Backspace, Ctrl+Enter and Alt+Enter because Backspace and Enter are handled with special path in mozilla::widget::NativeKey on Windows https://reviewboard.mozilla.org/r/76836/#review74968

Comment on attachment 8788284 [details] Bug 1300319 part.1 NativeKey::IsControlChar() should return true when the char is 0x7F (control character, DELETE) https://reviewboard.mozilla.org/r/76834/#review74970

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/73b2d83a2607 part.0 Add automated tests for Ctrl+Backspace, Alt+Backspace, Ctrl+Enter and Alt+Enter because Backspace and Enter are handled with special path in mozilla::widget::NativeKey on Windows r=m_kato https://hg.mozilla.org/integration/autoland/rev/2513e89e3ed3 part.1 NativeKey::IsControlChar() should return true when the char is 0x7F (control character, DELETE) r=m_kato

Comment on attachment 8788283 [details] Bug 1300319 part.0 Add automated tests for Ctrl+Backspace, Alt+Backspace, Ctrl+Enter and Alt+Enter because Backspace and Enter are handled with special path in mozilla::widget::NativeKey on Windows Approval Request Comment [Feature/regressing bug #]: Bug 1293505 [User impact if declined]: Cannot use Ctrl+Backspace [Describe test coverage new/current, TreeHerder]: Landed on m-c and adding automated tests. [Risks and why]: Nothing, this is only adding automated tests for this. [String/UUID change made/needed]: Nothing.

Comment on attachment 8788284 [details] Bug 1300319 part.1 NativeKey::IsControlChar() should return true when the char is 0x7F (control character, DELETE) Approval Request Comment [Risks and why]: Low. NativeKey::IsControlChar() doesn't return true when given character is U+007F. Ctrl+Backspace causes inputting U+007F on Windows. Therefore, the patch for bug 1293505 judges Ctrl+Backspace is a printable key event. So, this patch makes Ctrl+Backspace non-printable key event. [String/UUID change made/needed]: Nothing.

Tracking 51+ for this regression.

https://hg.mozilla.org/mozilla-central/rev/73b2d83a2607 https://hg.mozilla.org/mozilla-central/rev/2513e89e3ed3

Hello Alice 0775White, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment on attachment 8788284 [details] Bug 1300319 part.1 NativeKey::IsControlChar() should return true when the char is 0x7F (control character, DELETE) Recent regression, Aurora50+

https://hg.mozilla.org/releases/mozilla-aurora/rev/245983b752c0 https://hg.mozilla.org/releases/mozilla-aurora/rev/a1b9426c54bc

(In reply to Ritu Kothari (:ritu) from comment #17) > Hello Alice 0775White, could you please verify this issue is fixed as > expected on a latest Nightly build? Thanks! The problem is reproduced on Nightly51.0a1(2016-Sep-06). And I can verified to fix on Nightly51.0a1(2016-Sep-07) and Aurora50.0a2(2016-Sep-07) as well.

(In reply to Alice0775 White from comment #20) > (In reply to Ritu Kothari (:ritu) from comment #17) > > Hello Alice 0775White, could you please verify this issue is fixed as > > expected on a latest Nightly build? Thanks! > > The problem is reproduced on Nightly51.0a1(2016-Sep-06). > And I can verified to fix on Nightly51.0a1(2016-Sep-07) and > Aurora50.0a2(2016-Sep-07) as well. Awesome! Thank you as always for being so prompt.