Currently we just skip MediaPrefs calls when we're running in the GPU process (Part 3 of bug 1288618). We probably want to find a way of making these accessible to the GPU process properly instead of just using default values. Using gfxVars is probably the easiest way to achieve this.

Comment on attachment 8798249 [details] [diff] [review] Use gfxVars for media prefs we need to access from the GPU process Note that these gfxVars lookups won't be live and you'll need to restart the browser for their values to update. I don't think that should matter too much.

Comment on attachment 8798249 [details] [diff] [review] Use gfxVars for media prefs we need to access from the GPU process Review of attachment 8798249 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine assuming jya is okay with liveness.

Comment on attachment 8798249 [details] [diff] [review] Use gfxVars for media prefs we need to access from the GPU process Review of attachment 8798249 [details] [diff] [review]: ----------------------------------------------------------------- to me it would be better to have the MediaPrefs initialize in the GPU process, it would be a one-liner , same as initialising gfxVars ::: dom/media/platforms/wmf/DXVA2Manager.cpp @@ +407,5 @@ > aFailureReason = nsPrintfCString("IDirect3D9Ex::GetAdapterIdentifier failed with error %X", hr); > return hr; > } > > + if (adapter.VendorId == 0x1022 && !gfx::gfxVars::PDMWMFSkipBlacklist()) { can't you initialize the MediaPrefs in the GPU process?

So, making MediaPrefs work in the GPU process isn't simple. It uses the Preferences API which isn't available. gfxPrefs has a manual backend which syncs values over IPDL in order to work in the GPU process. I don't think it's worth adding the same thing for MediaPrefs (since we're unlikely to need many of them in the GPU process), so how about we just move the relevant prefs across to gfxPrefs?

Comment on attachment 8798316 [details] [diff] [review] move-prefs-to-gfx Review of attachment 8798316 [details] [diff] [review]: ----------------------------------------------------------------- Disappointing that media related prefs are now defined in two different spots.

Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/96c3388d513e Use gfxPrefs for media vars that get accessed from the GPU process. r=jya