Closed
Bug 130071
Opened 23 years ago
Closed 23 years ago
The format of JA localized shortcut is incorrect
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: ftang, Assigned: ftang)
Details
(Keywords: intl)
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
ftang
:
review+
roc
:
superreview+
roc
:
approval+
|
Details | Diff | Splinter Review |
this is moved from bugscape.mcom.com bug number 10699. I close that bug and move
to here.
Opened: 2001-10-23 15:45
Build: JA 2001-10-20 Win32
Steps:
Open Preferences > Appearance > colors, look at the localized shortcuts.
Please refer to the attachment.
Actual:
The localized shortcut is displayed as "[name]:(shortcut)", eg: "”wŒi�F(B)".
Expected:
They should be displayed as "[name](shortcut):", eg: "”wŒi(B):".
1. All hiragana, katakana and kanji should be double-bute.
2. '(', ')', ':' and alphabets should be single-byte.
Note:
1. In JA NS4.x, the format of localized shortcut is correct.
2. For details, refer to the localization guideline in MSDN CD.
------- Additional Comment #1 From Rui Xu 2001-10-23 15:47 -------
Created an attachment (id=3551)
An example for JA shortcut format
------- Additional Comment #2 From Rui Xu 2001-10-23 15:59 -------
This problem is in whole JA NS6.2.
------- Additional Comment #3 From rchen@netscape.com 2001-10-23 16:10 -------
Netscape 6 uses XUL technology for UI, not MS Windows resources. The access key
display was implemented in the coding, not in the resources. To avaoid the
problems like this, the program needs to verify the last character to exclude
the character like ":".
Reassigned to ftang.
------- Additional Comment #4 From Rui Xu 2001-10-23 16:30 -------
Since we are still using some APIs to call system dialogs, like OPEN dialog, so
the shortcuts in our dialogs will be inconsistent with those in system dialogs.
------- Additional Comment #5 From ftang@netscape.com 2001-10-31 17:36 -------
good catch, set target for m0.9.7
------- Additional Comment #6 From ftang@netscape.com 2002-02-15 15:22 -------
nsbeta1- per meeting.
------- Additional Comment #7 From ftang@netscape.com 2002-02-21 19:35 -------
Created an attachment (id=4495)
patch v1 add () before last ":" if the last char is ":"
------- Additional Comment #8 From ftang@netscape.com 2002-03-05 16:48 -------
Created an attachment (id=4597)
v2 of patch after nhotta review it
------- Additional Comment #9 From Naoki Hotta 2002-03-06 11:01 -------
(From update of attachment 4597 [details])
r=nhotta
------- Additional Comment #10 From ftang@netscape.com 2002-03-07 14:23 -------
change it to nsbeta1+
Assignee | ||
Comment 1•23 years ago
|
||
copy from bugscape attachment
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Comment on attachment 73522 [details] [diff] [review]
v2 of patch after nhott review it.
this has been r=nhotta in bugscape bug 10699 at 2002-03-06 11:01
Attachment #73522 -
Flags: review+
Assignee | ||
Comment 4•23 years ago
|
||
copy the cc list and other item from bugscape.
Comment 6•23 years ago
|
||
sr=hyatt
Assignee | ||
Updated•23 years ago
|
Comment on attachment 73522 [details] [diff] [review]
v2 of patch after nhott review it.
a=roc+moz
Attachment #73522 -
Flags: superreview+
Attachment #73522 -
Flags: approval+
Assignee | ||
Comment 8•23 years ago
|
||
fixed and check in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
It is still reproducible with 20020419 JA build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•23 years ago
|
||
the problem is my patch check the single byte ":" but the japanese localized
build use the double byte ":" (U+FF1A)
this could be fixed in localization process by changing the \uff1a to :
>Expected:
>They should be displayed as "[name](shortcut):", eg: "”wŒi(B):".
>1. All hiragana, katakana and kanji should be double-bute.
>2. '(', ')', ':' and alphabets should be single-byte.
Since the bug report said the ':' and '(', ')' should be single-byte and we do
implement it, therefore I close this bug.
Please open bugscape bug to ask localization engineer to change the localized
string to single byte '(', ')', and ':'. Thanks
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 11•23 years ago
|
||
We have more complex process for the translation, changing this character could
cost us more, plus it's very hard to ask the translator, which one use
singlebyte : and which one to use double byte :
I think the best way is, make the code know both singlebyte : and unicode :
Please reopen
You need to log in
before you can comment on or make changes to this bug.
Description
•