Thunderbird 51.0a1 (20160905030200) with built-in Lightning and fresh profile Steps to reproduce: Switch to calendar view Press keyboard shortcut (Ctrl+I) to create new event Press keyboard shortcut (Ctrl+D) to create new task Actual result: Nothing happens. Error Console shows: ReferenceError: openNewEvent is not defined ReferenceError: openNewTask is not defined

This has no l10n impact, but the functions are not available in the calling context. Paul, can you take a look at this, too? This is a regression of the event-in-a-tab implemnetation.

For the dialog window case this patch just adds functions to send messages to the iframe's contents to call the existing functions there. While testing I discovered the new message and new address book menu commands in the dialog window were also not working. This patch fixes them by moving the relevant functions out of the iframe. For the tab case some unneeded commands in lightning-item-panel.xul were overriding the keyboard shortcuts defined for the new event/task commands in the 'events and tasks' menu, and removing them fixed the problem. This patch also removes all other unnecessary items from lightning-item-panel.xul to avoid any other potential problems. The privacy toolbar button's drop-down menu wasn't working due to a trivial bad lookup, and this patch fixes it. To address in a follow-up bug: 'Page Setup' menu command in dialog window case is not working. (PrintUtils is not defined.)

Comment on attachment 8816730 [details] [diff] [review] keyboard-shortcuts-new-events-tasks.patch Review of attachment 8816730 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. r+ with the comments considered. Please also keep in mind bug 581817 when looking at the print commands. ::: calendar/lightning/content/lightning-item-panel.js @@ +413,5 @@ > + null, > + Components.interfaces.nsIMsgCompType.New, > + Components.interfaces.nsIMsgCompFormat.Default, > + null, > + null); Can you make this MailServices.compose.OpenComposeWindow( null, null, null, Components.interfaces.nsIMsgCompType.New, Components.interfaces.nsIMsgCompFormat.Default, null, null ); @@ +423,5 @@ > +function openNewCardDialog() { > + window.openDialog( > + "chrome://messenger/content/addressbook/abNewCardDialog.xul", > + "", > + "chrome,modal,resizable=no,centerscreen"); Same here.

Paul, any chance you can upload an updated patch with the review comments considered before the upcoming merge day in about one week from now so we get this in shape for 52 beta?

This patch addresses the comments on previous one.

Will this be backported to Thunderbird 52?

Comment on attachment 8827297 [details] [diff] [review] keyboard-shortcuts-new-events-tasks-2.patch Yes, it should, thanks for checking.

Beta (TB 52, Calendar 5.2): https://hg.mozilla.org/releases/comm-beta/rev/5a18517aaea59ecde013dbb60a95d8131539e3d6

Sorry: Beta (TB 52, Calendar 5.4).