Closed Bug 1300869 Opened 8 years ago Closed 8 years ago

Dimmed highlighting mode on sometimes wraps the text line of the text being searched for

Categories

(Toolkit :: Find Toolbar, defect)

defect
Not set
normal
Points:
2

Tracking

()

VERIFIED FIXED
mozilla52
Iteration:
51.3 - Sep 19
Tracking Status
firefox51 + verified
firefox52 --- verified

People

(Reporter: jaws, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image Capture.PNG (deleted) —
For example: If the text has the string "positionLabel" and I search for "positionLabel" then I may see: [posi]_________ tionLabel The [posi] part is yellow. The underscores is a blank white space, and the "tionLabel" is the rest of the search term but placed directly below the yellow area and without any highlighting or selection. See attached screenshot. I can reproduce this easily on Firefox Nightly 2016-09-06 on Windows 10 when on MozReview.
Summary: Dimmed highlighting mode on Mozreview sometimes wraps the text line of the text being searched for → Dimmed highlighting mode on sometimes wraps the text line of the text being searched for
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 51.3 - Sep 19
Points: --- → 5
Flags: qe-verify+
Flags: firefox-backlog+
Points: 5 → 2
Blocks: 1302281
Comment on attachment 8790694 [details] Bug 1300869 - don't allow whitespace wrapping in find toolbar modal highlighting boxes. https://reviewboard.mozilla.org/r/78394/#review77352
Attachment #8790694 - Flags: review?(jaws) → review+
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f7f5ce39b7d don't allow whitespace wrapping in find toolbar modal highlighting boxes. r=jaws
As I just noted over in bug 1282752 comment 12, I suspect the "white-space:nowrap" fix here might be preventing that other bug's fix from being effective. Perhaps we should back out this bug and come up with a different fix here? Unless I'm misunderstanding, "white-space:nowrap" seems like a pretty arbitrary/severe restriction, since we're allowing for search results that are legitimately wrapped to several lines.
Flags: needinfo?(mdeboer)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
QA Contact: brindusa.tot
I don't think it's a severe restriction, but it might be better to put the style on the 'outlineText' instead of its parent node. But the meat of your issue, Daniel, is being discussed back in bug 1282752. Thanks for helping out!
Flags: needinfo?(mdeboer)
Right -- it's not actually as severe as I thought, if we can manually slice up the range and position the pieces independently. Thanks!
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 I reproduced the initial issue using Nightly 51.0a1 (Build ID: 20160911030419) on Windows 10 x86_64. Reproduced also all the duplicates issues from bugs: 1301939, 1302022, 1302161, 1302281 and 1302743. Verified fixed on Windows 10, Ubuntu 16.04 and Mac OS X 10.11 using the latest Nightly 52.0a2 (Build ID: 20160922030437). Also, I can confirm the fixes for all the duplicates of this bug.
Since this is disabled in Firefox 51, shouldn't the tracking flag for Firefox 51 be removed and set to Firefox 52?
Status: RESOLVED → VERIFIED
Target Milestone: mozilla51 → mozilla52
Verified fixed FX 51b1, Win 7.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: