Closed
Bug 1301201
Opened 8 years ago
Closed 8 years ago
Avoid inheriting the origin attributes of the subject principal if it's system
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8789065 -
Flags: review?(bzbarsky)
Comment 2•8 years ago
|
||
Comment on attachment 8789065 [details] [diff] [review]
Avoid inheriting the origin attributes of the subject principal if it's system
r=me. Though in the expanded/system principal case maybe it would make sense to inherit aParent's origin attributes?
Attachment #8789065 -
Flags: review?(bzbarsky) → review+
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8789065 [details] [diff] [review]
> Avoid inheriting the origin attributes of the subject principal if it's
> system
>
> r=me. Though in the expanded/system principal case maybe it would make
> sense to inherit aParent's origin attributes?
Hmm, maybe, but I'm curious to know your reasoning. Can you please elaborate?
(FWIW I think we should make that change in a separate bug, if needed.)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0322637f5ea
Avoid inheriting the origin attributes of the subject principal if it's system; r=bzbarsky
Comment 5•8 years ago
|
||
> Hmm, maybe, but I'm curious to know your reasoning. Can you please elaborate?
Sure. Consider the "chrome or expanded principal calls window.open on a content window" case. I think after the changes in this bug, that window will not be opened with any interesting OA, but it might make sense to use the OA of the content window the open() call happened on.
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•