We should at least copy the top sites telemetry and add something similar for highlights. If we already start a telemetry session for panels then we should make sure that we do not use the "top sites panel" session but use a new one if activity stream is enabled.

This is the first set of probes. I tried to copy the style we already use in the app. Those patches do not cover all use cases yet.

Comment on attachment 8813737 [details] Bug 1301468 - AS Top Sites: Add LOAD_URL telemetry. https://reviewboard.mozilla.org/r/95116/#review96102

Comment on attachment 8813738 [details] Bug 1301468 - AS Highlights: Add LOAD_URL telemetry. https://reviewboard.mozilla.org/r/95118/#review96104

Comment on attachment 8813739 [details] Bug 1301468 - AS Top Sites: Add telemetry for showing context menu. https://reviewboard.mozilla.org/r/95120/#review96106

Comment on attachment 8813740 [details] Bug 1301468 - Add telemetry to AS context menu (following the pattern of existing probes). https://reviewboard.mozilla.org/r/95122/#review96108

Comment on attachment 8813741 [details] Bug 1301468 - Add activity stream session for new tab panel. https://reviewboard.mozilla.org/r/95124/#review96112 ::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStreamHomeFragment.java:83 (Diff revision 1) > + > + isSessionActive = false; > + } > + } > + > + private void sendPanelShownTelemetry() { I've noticed that the HomePager already sends sessions for the various homepanels - I'm wondering whether it would be better to modify that to just send a different panel ID when AS is enabled in: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/HomePager.java?q=path%3AHomePager&redirect_type=single#545 (Currently we'd just send the topsites panel ID for ActivityStream, which isn't all that useful - but we'd keep sending that even when showing Activity Stream instead of topsites with this patch.) That would make the HomePager code more complicated, but it might be easier to directly compare usage patterns for old topsites vs new Activity Stream? I'm not sure what's easier/more useful to analyse.

(In reply to Andrzej Hunt :ahunt from comment #11) > I've noticed that the HomePager already sends sessions for the various > homepanels - I'm wondering whether it would be better to modify that to just > send a different panel ID when AS is enabled in: > https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/ > mozilla/gecko/home/HomePager.java?q=path%3AHomePager&redirect_type=single#545 > > (Currently we'd just send the topsites panel ID for ActivityStream, which > isn't all that useful - but we'd keep sending that even when showing > Activity Stream instead of topsites with this patch.) > > That would make the HomePager code more complicated, but it might be easier > to directly compare usage patterns for old topsites vs new Activity Stream? > I'm not sure what's easier/more useful to analyse. Good point. The existing session seems to work a bit differently. It doesn't start when the app is launched (only when panels are switched) and it doesn't seem to reliably stop when a different screen is shown (resume/pause). But I agree that we shouldn't track this as showing the top sites panel. So in a follow-up bug I'd like to send a different panel ID for AS and then we can look at the data and compare the sessions.

Pushed by s.kaspari@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5bb4e5f0635a AS Top Sites: Add LOAD_URL telemetry. r=ahunt https://hg.mozilla.org/integration/autoland/rev/3c810092f398 AS Highlights: Add LOAD_URL telemetry. r=ahunt https://hg.mozilla.org/integration/autoland/rev/bab6db941756 AS Top Sites: Add telemetry for showing context menu. r=ahunt https://hg.mozilla.org/integration/autoland/rev/3a2e2cbe04c0 Add telemetry to AS context menu (following the pattern of existing probes). r=ahunt https://hg.mozilla.org/integration/autoland/rev/bf33178d80fa Add activity stream session for new tab panel. r=ahunt

https://hg.mozilla.org/mozilla-central/rev/5bb4e5f0635a https://hg.mozilla.org/mozilla-central/rev/3c810092f398 https://hg.mozilla.org/mozilla-central/rev/bab6db941756 https://hg.mozilla.org/mozilla-central/rev/3a2e2cbe04c0 https://hg.mozilla.org/mozilla-central/rev/bf33178d80fa