Closed
Bug 1301692
Opened 8 years ago
Closed 8 years ago
deleting a disabled property leaves a trace in the style editor
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file)
I noticed this while working on bug 1301078. STR: Open rule view. Add a new commented-out property, e.g. by pasting in "/* background: yellow; */". Now select the property name, clear it, type enter -- this deletes the property. Switch to style editor. I see: #testid { font-size: 4em; /*! */ } The editing has left the mostly-empty comment behind. I think this is just a small oversight in RuleRewriter.removeProperty.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8793390 [details] Bug 1301692 - remove comment when deleting disabled property; https://reviewboard.mozilla.org/r/80142/#review79200 Works well, and looks good.
Attachment #8793390 -
Flags: review?(pbrosset) → review+
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f41d2e492db remove comment when deleting disabled property; r=pbro
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3f41d2e492db
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•