Closed Bug 1301715 Opened 8 years ago Closed 8 years ago

Extract website metadata while browsing websites (for Activity Stream)

Categories

(Firefox for Android Graveyard :: General, defect, P1)

All
Android
defect

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

(Whiteboard: [MobileAS])

Attachments

(3 files)

See bug 1288330. For activity stream we require some metadata about the websites visited. While browsing we already download the document and images, so it makes sense to extract and store some of that. This bug is just about the extracting part.
Depends on: 1301718
Blocks: 1301718
No longer depends on: 1301718
Priority: P2 → P1
Comment on attachment 8789874 [details] Bug 1301715 - Extract website metadata and make it available. https://reviewboard.mozilla.org/r/77928/#review79526 ::: mobile/android/chrome/content/browser.js:3946 (Diff revision 2) > }.bind(this); > > this.browser.addEventListener("pagehide", listener, true); > } > + > + WebsiteMetadata.parseAsynchronously(this.browser.contentDocument); I wonder if we should make this conditional on AS being enabled, as to avoid unnecessary page processing? On a similar note: can we add performance telemetry? (I'm not quite sure what we should be measuring though. Any significant performance impacts should hopefully be visible on perfherder, but we could maybe also measure parsing time directly?)
Attachment #8789874 - Flags: review?(ahunt) → review+
Attachment #8789875 - Flags: review?(ahunt) → review+
(In reply to Andrzej Hunt :ahunt from comment #5) > I wonder if we should make this conditional on AS being enabled, as to avoid > unnecessary page processing? That's what I was wondering too. Enabling this for all now would have the advantage that we start with data as soon as we enable Activity Stream. Eventually I was thinking about replacing our icon extraction code with this too. > On a similar note: can we add performance telemetry? (I'm not quite sure > what we should be measuring though. Any significant performance impacts > should hopefully be visible on perfherder, but we could maybe also measure > parsing time directly?) This is a good point. This shouldn't affect page loading time though.
(In reply to Sebastian Kaspari (:sebastian) from comment #7) > (In reply to Andrzej Hunt :ahunt from comment #5) > > I wonder if we should make this conditional on AS being enabled, as to avoid > > unnecessary page processing? > > That's what I was wondering too. Enabling this for all now would have the > advantage that we start with data as soon as we enable Activity Stream. > Eventually I was thinking about replacing our icon extraction code with this > too. I added another patch to only enable this if the AS or Nightly flag is enabled. Nightly only so that this code is run already and we can find issues with it already.
Comment on attachment 8796589 [details] Bug 1301715 - Only extract metadata if the Activity Stream or Nightly flag is enabled. https://reviewboard.mozilla.org/r/82392/#review81780
Attachment #8796589 - Flags: review?(ahunt) → review+
Pushed by s.kaspari@gmail.com: https://hg.mozilla.org/integration/autoland/rev/479f64142010 Extract website metadata and make it available. r=ahunt https://hg.mozilla.org/integration/autoland/rev/a8e194e02cce BrowserApp: Receive metadata from event. r=ahunt https://hg.mozilla.org/integration/autoland/rev/db7f17f568db Only extract metadata if the Activity Stream or Nightly flag is enabled. r=ahunt
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Iteration: --- → 1.6
Depends on: 1425034
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: