Closed Bug 1301723 Opened 8 years ago Closed 8 years ago

Add automated tests for unsubmitted crash reports notification

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Version:
49 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: mconley, Unassigned)

References

Details

Attachments

(2 files)

Bug 1301723 - Add automated tests for the unsubmitted crash report notification.
(deleted), text/x-review-board-request
Felipe
: review+
Details
Disable test if crashreporter not available
(deleted), patch
mconley
: checkin+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1287178 +++ Spinning this out from bug 1287178. This notification shows up soon after start-up if the user has unsubmitted crash reports in their queue. We need automated tests for this stuff.
Attachment #8790470 - Flags: review?(felipc)
Hey felipe, I promise I won't make you review all of these pending crash report notification bugs. I'll start spreading it out a bit more for the rest of the follow-up bugs!
Comment on attachment 8790470 [details] Bug 1301723 - Add automated tests for the unsubmitted crash report notification. https://reviewboard.mozilla.org/r/78262/#review76832
Attachment #8790470 - Flags: review?(felipc) → review+
(In reply to Mike Conley (:mconley) - (Digging through needinfos and reviews) from comment #2) > Hey felipe, > > I promise I won't make you review all of these pending crash report > notification bugs. I'll start spreading it out a bit more for the rest of > the follow-up bugs! Hey, no worries. Keep 'em coming! Also, I may or may not have some patches for you to review soon.. ;)
Blocks: 1301722
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33de74be048e Add automated tests for the unsubmitted crash report notification. r=Felipe
Pushed by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6949e171dfd4 Follow up: disable browser_UnsubmittedCrashHandler.js test if crash reporter not available. r=test-only
Whoops - looks like I broke ASAN builds. Again. I need to remember that crash reporter isn't available for all builds!
Comment on attachment 8791324 [details] [diff] [review] Disable test if crashreporter not available (And this patch was pushed in by KWierso in comment 6)
Attachment #8791324 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/33de74be048e https://hg.mozilla.org/mozilla-central/rev/6949e171dfd4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1303067
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: