Closed Bug 1301999 Opened 8 years ago Closed 8 years ago

Array indices lower than length of generic objects appear hidden in console

Categories

(DevTools :: Console, defect)

45 Branch
defect
Not set
normal

Tracking

(firefox48 wontfix, firefox49 wontfix, firefox50 wontfix, firefox51 verified)

VERIFIED FIXED
Firefox 51
Tracking Status
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- verified

People

(Reporter: Oriol, Assigned: Oriol)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch generic-object-v1.patch (deleted) — Splinter Review
Enter a generic object with a length property and some array indices to the console: ({0: 0, 1: 1, 2: 2, 3: 3, length: 2}) The preview shows Object { 2: 2, 3: 3, length: 2, 2 more… } instead of Object { 0: 0, 1: 1, 2: 2, 3: 3, length: 2 } I wondered what was the point of doing that. It seems it was just a mistake of bug 1035545. It added an additional argument to GenericObject without realizing it was already called with a third argument.
Attachment #8790128 - Flags: review?(nfitzgerald)
Comment on attachment 8790128 [details] [diff] [review] generic-object-v1.patch Review of attachment 8790128 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8790128 - Flags: review?(nfitzgerald) → review+
Version: unspecified → 45 Branch
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/b532ddbe9b41 Stop hiding array indices of generic objects in console. r=fitzgen
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
I have reproduced this bug with Nightly 51.0a1 (2016-09-11) (64-bit) on Windows 7 , 64 Bit ! This bug's fix is verified with latest Aurora (Developer Edition) Build ID : 20160922004007 User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0 [bugday-20160921]
There has been a regression and so this issue is present again in Nightly, i.e. entering in Web Console: ({0: 0, 1: 1, 2: 2, 3: 3, length: 2}) the preview shows: Object { 2: 2, 3: 3, length: 2, 2 more… Regression window: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=37f78aca862224d7151c0fcae1ed8373fe11c83b&tochange=a5510966f80b9b2f5abf59ab32cf4c92d66c60de Among the changes pushed that day (2016-10-07) it was one for bug 1304178 ("Pref on the new console frontend in nightly"). This must have caused this. In most current Dev edition 51.0a2 x64 (2016-11-14) the issue is not present - tested in win 10 x64. (In Dev edition the old console is still enabled by default, so I suppose that's why the issue is not present there).
(In reply to Kostas from comment #6) > There has been a regression and so this issue is present again in Nightly, > i.e. entering in Web Console: > ({0: 0, 1: 1, 2: 2, 3: 3, length: 2}) > the preview shows: > Object { 2: 2, 3: 3, length: 2, 2 more… > > Regression window: > https://hg.mozilla.org/integration/fx-team/ > pushloghtml?fromchange=37f78aca862224d7151c0fcae1ed8373fe11c83b&tochange=a551 > 0966f80b9b2f5abf59ab32cf4c92d66c60de > > Among the changes pushed that day (2016-10-07) it was one for bug 1304178 > ("Pref on the new console frontend in nightly"). > This must have caused this. > > In most current Dev edition 51.0a2 x64 (2016-11-14) the issue is not present > - tested in win 10 x64. > (In Dev edition the old console is still enabled by default, so I suppose > that's why the issue is not present there). Thanks for the heads up. I filed Bug 1317502 to track the fix for this in the Reps system that the new console frontend is using.
Depends on: 1317502
Depends on: 1314571
I have reproduced this bug with Firefox nightly 51.0a1(build ID:20160911030419)on windows 7(64 bit) I have verified this bug as fixed with Firefox beta 51.0b12(build ID:20170105155013) User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 [testday-20170106]
(In reply to Kazi Nuzhat Tasnem from comment #9) > I have reproduced this bug with Firefox nightly 51.0a1(build > ID:20160911030419)on > windows 7(64 bit) > > I have verified this bug as fixed with Firefox beta 51.0b12(build > ID:20170105155013) > User Agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 > Firefox/51.0 > > [testday-20170106] Thank you for verifying this bug!
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: