Closed Bug 1302009 Opened 8 years ago Closed 8 years ago

Allow passing an empty Endpoint<> over IPDL

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- fix-optional
firefox52 --- fixed

People

(Reporter: mattwoodrow, Assigned: dvander)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
For VideoDecoding, we want to fail the initialization if there isn't a GPU process. The simplest way to do this is to allow returning an empty Endpoint<> from the parent process when we couldn't connect to the GPU process.
Assignee: nobody → dvander
Attached patch patch (obsolete) (deleted) — — Splinter Review
Shortcut on reading/writing invalid Endpoints, instead of using MOZ_RELEASE_ASSERT. We still release assert when binding an invalid Endpoint though. This will let us handle failures easier.
Attachment #8790588 - Flags: review?(wmccloskey)
Comment on attachment 8790588 [details] [diff] [review] patch Review of attachment 8790588 [details] [diff] [review]: ----------------------------------------------------------------- I think we need a public IsValid() function added to Endpoint, since mValid is private.
Attached patch patch (deleted) — — Splinter Review
Whoops, you're right.
Attachment #8790588 - Attachment is obsolete: true
Attachment #8790588 - Flags: review?(wmccloskey)
Attachment #8790853 - Flags: review?(wmccloskey)
Status: NEW → ASSIGNED
Attachment #8790853 - Flags: review?(wmccloskey) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee6bf23101a Allow passing an empty Endpoint over IPDL. (bug 1302009, r=billm)
https://hg.mozilla.org/mozilla-central/rev/4ee6bf23101a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Blocks: 1305320
Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.
status-firefox51: affected → fix-optional
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: