This logging is way too spammy. For instance, about a third of this log is "GC found live" output: https://treeherder.mozilla.org/logviewer.html#?job_id=4824714&repo=mozilla-central The total output should be capped at, say, 20 lines. Maybe it could also print out the total number of found live objects, and have an environment variable to print them all out, but the current default is not okay. It also makes investigating leaks locally difficult.

Does this look about right? I didn't test with an actual leaking browser, though I did compile once skipping is ``if (!arenaLists[kind].isEmpty())`` test, and it at least printed out the total of 0.

Comment on attachment 8790484 [details] [diff] [review] Limit number of ERROR: GC found live Cell messages Review of attachment 8790484 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: js/src/jsgc.cpp @@ +3572,3 @@ > #ifdef DEBUG > if (!arenaLists[kind].isEmpty()) { > + size_t max_cells = 20; Make this const?

(In reply to Andrew McCreight [:mccr8] from comment #2) > @@ +3572,3 @@ > > #ifdef DEBUG > > if (!arenaLists[kind].isEmpty()) { > > + size_t max_cells = 20; > > Make this const? Can't. I'm setting it to $JS_GC_MAX_LIVE_CELLS if given. I really ought to make a more generic mechanism for configuring all this tracing and profiling goop, I suppose.

Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c68f029d6c55 Limit number of ERROR: GC found live Cell messages, r=mccr8