Closed Bug 1302744 Opened 8 years ago Closed 8 years ago

missing chrome://pocket/skin/toolbar-lunaSilver.png referenced from chrome://pocket/skin/pocket.css

Categories

(Firefox :: Pocket, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Found as part of bug 1302570. I think the problem has been introduced in bug 1230638 but I'm not sure. Interestingly my test gives different output for Windows and non-Windows here. On Windows I have: missing chrome://pocket/skin/toolbar-lunaSilver.png referenced from chrome://pocket/skin/pocket.css On Linux I have: missing chrome://pocket/skin/toolbar-lunaSilver.png referenced from jar:file:///builds/slave/test/build/application/firefox/browser/features/firefox@getpocket.com.xpi!/chrome/skin/windows/pocket.css On Mac I have: missing chrome://pocket/skin/toolbar-lunaSilver.png referenced from jar:file:///builds/slave/test/build/application/Nightly.app/Contents/Resources/browser/features/firefox@getpocket.com.xpi!/chrome/skin/windows/pocket.css I've finally understood that the error on Windows is because the file is packaged with an uppercase t (*T*oolbar) but used in the CSS file with a lowercase t (*t*oolbar). The Linux/Mac errors are because chrome://pocket/skin/ doesn't point to windows/ folder there, so we can silence the error by using a relative path.
Attached patch Fix (deleted) — Splinter Review
Attachment #8791227 - Flags: review?(gijskruitbosch+bugs)
Assignee: nobody → florian
Status: NEW → ASSIGNED
I created https://github.com/mozilla-partners/pocket/pull/5 . Shane, can you review/merge? How does this reach central?
Assignee: florian → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mixedpuppy)
Comment on attachment 8791227 [details] [diff] [review] Fix m-c isn't the canonical repo for pocket, but figurative r+ because I just wrote the same patch - though I added a semicolon.
Attachment #8791227 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: nobody → florian
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/fa789486a02576cda9bb5fc2d289657e2f9b6e3a Bug 1302744 - Fix reference to toolbar-lunaSilver.png from chrome://pocket/skin/pocket.css, r=Gijs.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
pull merged
Flags: needinfo?(mixedpuppy)
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #7) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ef41af900ec Looks like you used the wrong bug number in your commit.
Flags: needinfo?(schien)
(In reply to Florian Quèze [:florian] [:flo] from comment #8) > (In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment > #7) > > https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ef41af900ec > > Looks like you used the wrong bug number in your commit. sorry my bad and thanks for the reminder.
Flags: needinfo?(schien)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: