Open
Bug 1302793
Opened 8 years ago
Updated 2 years ago
Hook up bitrate adaptation for audio-only calls, and audio/video calls when at low bandwidth
Categories
(Core :: WebRTC: Networking, defect, P3)
Core
WebRTC: Networking
Tracking
()
People
(Reporter: jesup, Unassigned)
References
Details
(Whiteboard: [blocked on webrtc.org 49 update])
Attachments
(1 file)
(deleted),
patch
|
pkerr
:
review+
|
Details | Diff | Splinter Review |
Audio-only calls should use bitrate adaptation when possible.
A/V calls should adapt the audio bitrate down when the total number of bits gets "low", with a fair bit of hysteresis.
Reporter | ||
Updated•8 years ago
|
Rank: 15
Reporter | ||
Comment 1•8 years ago
|
||
This will probably need some tweaks on debugging and to the algorithm for allocating audio bits, so there will be a followup, and I haven't run Trys yet. Note this patch requires the update_49 queue, so it's gated on that.
Attachment #8795299 -
Flags: review?(pkerr)
Reporter | ||
Updated•8 years ago
|
Whiteboard: [blocked on webrtc.org 49 update]
Updated•8 years ago
|
Attachment #8795299 -
Flags: review?(pkerr) → review+
Reporter | ||
Comment 2•8 years ago
|
||
[Tracking Requested - why for this release]:
the blocking bug landed in 53. Getting ready to finish cleanup and testing of this patch for 53
Reporter | ||
Comment 5•8 years ago
|
||
(In reply to Iulia Cristescu, QA [:IuliaC] from comment #4)
> Hello! Is this still going to land in Firefox 52?
No. I hope to land this in 53 (the blocking bug, webrtc.org 49 update, landed in 53)
Flags: needinfo?(rjesup)
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Updated•8 years ago
|
status-firefox55:
--- → affected
tracking-firefox54:
+ → ---
Reporter | ||
Comment 6•7 years ago
|
||
Will need un-bitrotting, and testing/tests (though we don't have great (ok, any) ways to test actual bitrate adaptations)
Assignee: rjesup → dminor
Reporter | ||
Updated•7 years ago
|
Comment 7•7 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #6)
> Will need un-bitrotting, and testing/tests (though we don't have great (ok,
> any) ways to test actual bitrate adaptations)
Are you referring to automation or for development?
For development I would run a TURN server on a Linux machine and control the throughput through iptables or other tools. Or maybe you can even do it directly on the Linux dev machine?
On Mac I installed Apple's "Network Link Conditioner", but I have to admit I never tried it for real.
Comment hidden (obsolete) |
Updated•7 years ago
|
Rank: 15 → 21
Priority: P1 → P2
Keywords: stale-bug
Comment 9•7 years ago
|
||
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Updated•4 years ago
|
Assignee: dminor → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•