Closed
Bug 1302879
Opened 8 years ago
Closed 8 years ago
Intermittent devtools/client/responsive.html/test/browser/browser_device_change.js | Test timed out -
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox50 unaffected, firefox51 fixed, firefox52 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | fixed |
firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: zer0)
References
Details
(Keywords: intermittent-failure, Whiteboard: [multiviewport][reserve-rdm])
Attachments
(1 file)
Filed by: wkocher [at] mozilla.com
https://treeherder.mozilla.org/logviewer.html#?job_id=35849739&repo=mozilla-inbound
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1473854227/mozilla-inbound_win7_vm-debug_test-mochitest-e10s-devtools-chrome-5-bm129-tests1-windows-build365.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 3•8 years ago
|
||
Very frequent and clearly fallout from bug 1254388.
Blocks: 1254388
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
status-firefox52:
--- → affected
Flags: needinfo?(zer0)
Updated•8 years ago
|
Whiteboard: [multiviewport] [triage]
Comment hidden (Intermittent Failures Robot) |
Priority: -- → P3
Whiteboard: [multiviewport] [triage] → [multiviewport][reserve-rdm]
:zer0 is investigating this.
Assignee: nobody → zer0
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 52.1 - Oct 3
Flags: qe-verify-
Priority: P3 → P1
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
I faced this issue working on bug 1276971.
Basically with bug 1254388, now we automatically enable the touch event if the device selected in the dropdown is a touch device. Unfortunately, that also means that we reload the content page. Sometimes, we have a racing condition where the content is adding the listener to emit the `content-resize` too late – when the resize already happened – therefore the test hangs forever, waiting for something it would never happens.
This patch fixes the `waitForViewportResizeTo` function used in the tests, taking in account the racing condition described above – and, to play safe, also the scenario where the size is already the one expected.
Flags: needinfo?(zer0)
Assignee | ||
Comment 8•8 years ago
|
||
At a first look, the oranges don't seem related to this patch.
Assignee | ||
Comment 9•8 years ago
|
||
Here the tree build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9397f0e224e
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8796235 [details]
Bug 1302879 - Intermittent browser_device_change.js | Test timed out;
https://reviewboard.mozilla.org/r/82140/#review80866
Seems like a reasonable fix to me, let's go with it. Thanks for working on this!
Attachment #8796235 -
Flags: review?(jryans) → review+
Comment 11•8 years ago
|
||
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/af6e01b8574b
Intermittent browser_device_change.js | Test timed out; r=jryans
Comment 12•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 13•8 years ago
|
||
bugherder uplift |
Flags: in-testsuite+
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 18•7 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•