Error in parsing value for ‘border’. Declaration dropped." {file: "chrome://mozapps/skin/aboutNetworking.css" line: 106 column: 10 source: " border: 1;} The related line is at http://searchfox.org/mozilla-central/rev/f6c298b36db67a7109079c0dd7755f329c1d58e2/toolkit/themes/shared/aboutNetworking.css#106

We should just remove this line.

Hi! I'm new here. I would like to take up the bug

(In reply to Amal Santhosh from comment #2) > Hi! I'm new here. I would like to take up the bug Go ahead! Let me know if you have questions.

Since I'm new to this, can u show me the way around. Thanks :)

Do you already have a copy of the source code? Have you built Firefox? Have you found the file that needs to be modified?

No I don't have the source code yet...

(In reply to Amal Santhosh from comment #6) > No I don't have the source code yet... This would be the first step: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

It's done. Thank you for your patience so far :) What will be the next thing to do? Thank you :)

(In reply to Amal Santhosh from comment #8) > It's done. Thank you for your patience so far :) > What will be the next thing to do? Find the file that you want to change. It's toolkit/themes/shared/aboutNetworking.css

I believe I have fixed the bug. The next step would be to create a patch right? I've tried http://mastro77.blogspot.in/2013/11/making-patch-in-mozillas-bugzilla.html for instructions but cant find a file called 'patches' in my '/mozilla-central/.hg/' directory.

Have you tried using just hg diff? hg diff > ../mypatch.diff would put mypatch.diff in the parent directory.

Please review my patch and kindly test it to see if it resolved the bug or not. Thank you :)

Looks good but somehow I can't apply the patch: $ hg import --no-commit https://bug1303356.bmoattachments.org/attachment.cgi?id=8793787 applying https://bug1303356.bmoattachments.org/attachment.cgi?id=8793787 patching file toolkit/themes/shared/aboutNetworking.css Hunk #1 FAILED at 102 1 out of 1 hunks FAILED -- saving rejects to file toolkit/themes/shared/aboutNetworking.css.rej abort: patch failed to apply Did you run './mach mercurial-setup'?

As you said, I ran the './mach mercurial-setup' command and it says "watchman" filesystem watching tool could not be found or isn't working. Look like I'll need to install it.

Hmm, I don't think watchman missing should matter for the patch. Did you manually edit the patch file after generating it? What's the content of your Mercurial configuration file (~/.hgrc)?

No I didn't edit the patch after generating. ~/.hgrc file contains atleast the lines specified in http://mastro77.blogspot.in/2013/11/making-patch-in-mozillas-bugzilla.html

So this is the line in aboutNetworking.css that should be removed (without quotes): " border: 1;" but this is the line your patch wants to remove: " border:1; " Since aboutNetworking.css doesn't have that line, the patch fails to apply. I suspect you modified the line, committed your changes, and then you deleted the line. So the patch is on top of your previously committed change rather than against mozilla-central tip.

Please review the following patch I have redone and kindly check if it fixes the bug this time around. Thank You :)

Comment on attachment 8793899 [details] [diff] [review] Removed 'border: 1;' from aboutNetworking.css at line 106 to fix the bug This works! Thanks.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c837d3718089 Remove bogus border property. r=dao

Is there anything more I have to do? Thanks :)

Nope, we're done here. I pushed your patch to the mozilla-inbound integration repository from where it will be merged to mozilla-central soon. Thanks!

Thank a lot for your guidance and patience in helping me resolve the bug :)