Closed
Bug 1303484
Opened 8 years ago
Closed 8 years ago
Intermittent devtools/client/responsive.html/test/browser/browser_device_modal_submit.js | Got expected number of devices in device selector. - Got 17, expected 18
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox50 unaffected, firefox51 fixed, firefox52 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | unaffected |
| firefox51 | --- | fixed |
| firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: zer0)
References
Details
(Keywords: intermittent-failure, Whiteboard: [multiviewport][reserve-rdm])
Attachments
(1 file)
| Comment hidden (Intermittent Failures Robot) |
|
||
Updated•8 years ago
|
Blocks: 1254385
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
status-firefox52:
--- → affected
Flags: needinfo?(zer0)
|
||
Updated•8 years ago
|
Whiteboard: [multiviewport] [triage]
|
||
Comment 2•8 years ago
|
||
May be useful to do something like:
// Wait until the viewport has been added and the device list has been loaded
yield waitUntilState(store, state => state.viewports.length == 1
&& state.devices.listState == Types.deviceListState.LOADED);
after adding and removing the device in browser_device_change.js
| Comment hidden (Intermittent Failures Robot) |
Priority: -- → P3
Whiteboard: [multiviewport] [triage] → [multiviewport][reserve-rdm]
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 6•8 years ago
|
||
I fixed that when I was working on bug 1276971; it was causing some side effects in the test that wasn't immediate to associate to this issue.
I spit the patch so we can land it sooner.
Here the try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a42e0c651e7&selectedJob=28363817
Flags: needinfo?(zer0)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → zer0
|
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 52.1 - Oct 3
Flags: qe-verify-
Priority: P3 → P1
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8797055 [details]
Bug 1303484 - browser_device_modal_submit.js | unexpected number of devices;
https://reviewboard.mozilla.org/r/82700/#review81528
Thanks, looks like a good improvement to me!
Attachment #8797055 -
Flags: review?(jryans) → review+
|
|
||
Updated•8 years ago
|
Iteration: 52.1 - Oct 3 → 52.2 - Oct 17
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/f927dc3ad864
browser_device_modal_submit.js | unexpected number of devices; r=jryans
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
|
||
Comment 10•8 years ago
|
||
| bugherder uplift | ||
Flags: in-testsuite+
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•