The transparency currently used on these icons is too high to satisfy accessibility requirements.

Comment on attachment 8793264 [details] [diff] [review] patch Review of attachment 8793264 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! ::: browser/themes/shared/jar.inc.mn @@ +71,2 @@ > skin/classic/browser/notification-icons.svg (../shared/notification-icons.svg) > +* skin/classic/browser/tracking-protection-16.svg (../shared/identity-block/tracking-protection-16.svg) It looks like the changes in this file are only reordering, right?

(In reply to Johann Hofmann [:johannh] from comment #1) > Comment on attachment 8793264 [details] [diff] [review] > patch > > Review of attachment 8793264 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good! > > ::: browser/themes/shared/jar.inc.mn > @@ +71,2 @@ > > skin/classic/browser/notification-icons.svg (../shared/notification-icons.svg) > > +* skin/classic/browser/tracking-protection-16.svg (../shared/identity-block/tracking-protection-16.svg) > > It looks like the changes in this file are only reordering, right? No, I've added * which enables preprocessing for these files.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6f520753a2 Increase opacity of icons in the main menu, identity block and control center in high-contrast mode and on Linux. r=jhofmann

backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=36282655&repo=mozilla-inbound

Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efcbe1b8f73a Backed out changeset 7d6f520753a2 for bustage on a CLOSED TREE

Looks like I need to remove Windows line endings from some SVG files. I don't understand why this was building locally on Linux, though.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2896b755b7 Increase opacity of icons in the main menu, identity block and control center in high-contrast mode and on Linux. r=jhofmann

[Tracking Requested - why for this release]: 51 introduced this regression which makes main menu icons harder to see.

Track 51+ as 51 introduced this regression. Hi :dao, Is this worth uplifting to 51?

Approval Request Comment [Feature/regressing bug #]: bug 1022573 only got us halfway there, this patch basically completes the fix [User impact if declined]: Icons in the main menu, identity block and control center hard to see in Windows high-contrast mode and in some cases on Linux [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: straightforward fix, low risk. This is easy to uplift now that we've already uplifted bug 1303291. [String/UUID change made/needed]: none

Comment on attachment 8797412 [details] [diff] [review] landed patch This patch polishes UI related to icon. Take it in 51 aurora.