Closed Bug 1304632 Opened 8 years ago Closed 8 years ago

add some CSS image value assertions

Categories

(Core :: CSS Parsing and Computation, defect, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(2 files)

Bug 1304632 - Part 1: Assert main thread in ImageValue destructor.
(deleted), text/x-review-board-request
bholley
: review+
Details
Bug 1304632 - Part 2: Remove unnecessary nsStyleImage::mImage null checking.
(deleted), text/x-review-board-request
bholley
: review+
Details
A couple of assertions that seemed worth adding while working on stylo background-image support.
Comment on attachment 8793637 [details] Bug 1304632 - Part 1: Assert main thread in ImageValue destructor. https://reviewboard.mozilla.org/r/80354/#review79108
Attachment #8793637 - Flags: review?(bobbyholley) → review+
Comment on attachment 8793638 [details] Bug 1304632 - Part 2: Remove unnecessary nsStyleImage::mImage null checking. https://reviewboard.mozilla.org/r/80356/#review79110
Attachment #8793638 - Flags: review?(bobbyholley) → review+
Priority: -- → P2
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f54a85a2b1c9 Part 1: Assert main thread in ImageValue destructor. r=bholley https://hg.mozilla.org/integration/autoland/rev/d87b0d8129a8 Part 2: Remove unnecessary nsStyleImage::mImage null checking. r=bholley
https://hg.mozilla.org/mozilla-central/rev/f54a85a2b1c9 https://hg.mozilla.org/mozilla-central/rev/d87b0d8129a8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: