Closed Bug 1304709 Opened 8 years ago Closed 8 years ago

Crash when entering master password after clicking "show passwords" and editor for username active [@ XUL@0x25b5367 | -[NSWindow _reallySendEvent:isDelayedEvent:] ]

Categories

(Core :: Widget: Cocoa, defect, P1)

52 Branch
Unspecified
macOS
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox52 --- affected

People

(Reporter: whimboo, Unassigned)

References

Details

(Keywords: crash, Whiteboard: tpi:+)

There is a reproducible crash for me: bp-6b09d147-6ee8-46ab-b190-bdab62160922 MOZ_CRASH Reason MOZ_CRASH(A password editor has focus, but not in secure input mode) Crash Reason EXC_BAD_ACCESS / KERN_INVALID_ADDRESS Crash Address 0x0 Top 10 frames: 0 XUL XUL@0x25b5367 1 AppKit -[NSWindow _reallySendEvent:isDelayedEvent:] 2 AppKit -[NSWindow sendEvent:] Ø 3 XUL XUL@0x25f2f9b 4 AppKit -[NSApplication sendEvent:] Ø 5 XUL XUL@0x25e5c9b Ø 6 XUL XUL@0x25e69f6 Ø 7 XUL XUL@0x258db46 Ø 8 XUL XUL@0x25e6e41 Ø 9 XUL XUL@0xd1acf Ø 10 XUL XUL@0xffab2 Steps to reproduce: 1. Create a fresh profile 2. Set a master password 3. Store some credentials for different sites 4. Open preferences and go to security -> saved logins 5. Double-click on the username so that the editor shows up 6. Click on "Show Passwords" 7. Start typing in the master password dialog With step 7 Firefox always crashes for me.
Here details with a local debug build: Hit MOZ_CRASH(A password editor has focus, but not in secure input mode) at /builds/slave/m-cen-m64-d-000000000000000000/build/src/widget/cocoa/nsChildView.mm:5368 #01: -[NSWindow sendEvent:][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x255539] #02: mac_plugin_interposing_child_OnShowCursor[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2f22d4c] #03: -[NSApplication sendEvent:][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x1d616a] #04: mac_plugin_interposing_child_OnShowCursor[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2f14298] #05: mac_plugin_interposing_child_OnShowCursor[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2f153c0] #06: mac_plugin_interposing_child_OnShowCursor[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2eac035] #07: mac_plugin_interposing_child_OnShowCursor[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2f15a7e] #08: XRE_AddJarManifestLocation[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x100343] #09: NS_InvokeByIndex[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x1139ef] #10: XRE_XPCShellMain[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0xb52f06] #11: XRE_XPCShellMain[/Volumes/data/code/gecko/obj/debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0xb552cd]
None of the relevant code (including the MP code) is in the password manager directory.
Component: Password Manager → Widget: Cocoa
Product: Toolkit → Core
Priority: -- → P1
Whiteboard: tpi:+
Hi Masayuki, this seems related to bug 893973. Would you be able to take a look?
Depends on: 893973
Flags: needinfo?(masayuki)
I just took a look at this bug and went through the STR from the description, with a fresh Nightly build. I can't replicate the crash. Henrik, can you please check if FF still crashes for you?
Flags: needinfo?(hskupin)
Yes, it seems to work now. I cannot reproduce this crash anymore with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:53.0) Gecko/20100101 Firefox/53.0 ID:20170112030301 CSet: 3e275d37a06236981bff399b7d7aa0646be3fee7
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(hskupin)
Resolution: --- → WORKSFORME
Flags: needinfo?(masayuki)
You need to log in before you can comment on or make changes to this bug.