Closed Bug 1304727 Opened 8 years ago Closed 8 years ago

Inspector layout broken if toolbox height is lower than 250px

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox52 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 52
Iteration:
52.1 - Oct 3
Tracking Flags:
Tracking Status
firefox52 --- verified

People

(Reporter: jdescottes, Assigned: Honza)

References

Details

(Whiteboard: [devtools-html])

Attachments

(2 files)

inspector-layout-broken-small-height.png
(deleted), image/png
Details
bug1304727.patch
(deleted), patch
jdescottes
: review+
Details | Diff | Splinter Review
Regression from inspector.xul migration to HTML (Bug 1262443) STRs: - open devtools, docked to bottom - resize toolbox height to be lower than 250px - close devtools - open devtools AR: Bottom of the toolbox is blank, layout looks buggy (see attachment) ER: Layout should be correct
Blocks: 1262443
Whiteboard: [devtools-html] [triage]
Blocks: devtools-html-phase2
Flags: qe-verify?
Attached patch bug1304727.patch (deleted) — — Splinter Review
Thanks for the report Julian! Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8794174 - Flags: review?(jdescottes)
Iteration: --- → 52.1 - Oct 3
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
There is also another STR that's fixed by the attached patch: 1) Open the Toolbox, the Inspector should be the default panel 2) Switch to the Network panel, reload the page, select an entry, the side panel should appear 3) Switch back to the Inspector panel, there is a gap at the bottom -> BUG Honza
Comment on attachment 8794174 [details] [diff] [review] bug1304727.patch Review of attachment 8794174 [details] [diff] [review]: ----------------------------------------------------------------- Fixes the issue, thank you Honza!
Attachment #8794174 - Flags: review?(jdescottes) → review+
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/d2bacbda0dcd Fix Inspector layout; r=jdescottes
Keywords: checkin-needed
Flags: qe-verify? → qe-verify+
QA Contact: cristian.comorasu
https://hg.mozilla.org/mozilla-central/rev/d2bacbda0dcd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
I reproduced this bug using Fx 52.0a1, build ID:20160922030437, on Windows 10 x64 and Mac OS X 10.10.5. I can confirm this issue is fixed, I verified using Fx 52.0a1 build ID:20160927030200, on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: