Closed Bug 1304790 Opened 8 years ago Closed 8 years ago

Add a telemetry probe that measures how long it takes for a content process to start up and communicate with the parent

Categories

(Core :: DOM: Content Processes, defect, P2)

50 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mconley, Assigned: benjamin)

References

Details

Attachments

(1 file)

This would be very useful for determining if slow content process start time is related to bug 1304393.
ni'ing as requested.
Flags: needinfo?(benjamin)
Flags: needinfo?(benjamin)
Attachment #8817649 - Flags: feedback?(francois)
Assignee: nobody → benjamin
Priority: -- → P2
Comment on attachment 8817649 [details] Bug 1304790 - Add a telemetry probe that measures how long it takes for a content process to start up and communicate back to the parent, data-r?francois https://reviewboard.mozilla.org/r/97868/#review98214 Excited (and maybe a little worried) to see the data here. Thanks! ::: toolkit/components/telemetry/Histograms.json:196 (Diff revision 1) > + "expires_in_version": "57", > + "bug_numbers": [1304790], > + "kind": "exponential", > + "high": 64000, > + "n_buckets": 100, > + "releaseChannelCollection": "opt-out", I guess we'll need a test for this in a follow-up bug? ::: toolkit/components/telemetry/Histograms.json:197 (Diff revision 1) > + "bug_numbers": [1304790], > + "kind": "exponential", > + "high": 64000, > + "n_buckets": 100, > + "releaseChannelCollection": "opt-out", > + "description": "Content process launch time until the GetXPCOMProcessAttributes message is received, from in milliseconds" Typo?: "from in milliseconds"
Attachment #8817649 - Flags: review?(mconley) → review+
Yes, I'll add a test if this metric shows value and we decide to keep it permanently.
Comment on attachment 8817649 [details] Bug 1304790 - Add a telemetry probe that measures how long it takes for a content process to start up and communicate back to the parent, data-r?francois https://reviewboard.mozilla.org/r/97868/#review98246 This is providing user value in the form of monitoring product quality issues. datareview+
Attachment #8817649 - Flags: review+
Attachment #8817649 - Flags: feedback?(francois)
Pushed by bsmedberg@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f00c6d7631bb Add a telemetry probe that measures how long it takes for a content process to start up and communicate back to the parent, r=mconley data-r=francois
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You will be glad to look at how this telemetry probe has been doing: https://health.graphics/quantum/track?metric=CONTENT_PROCESS_LAUNCH_TIME_MS Something landed in February which made things an order of magnitude better.
I don't think that's real. It used to measure how long it would take for the content process to start up and send its first message to the parent. Now it just measures launch time. Mike pointed this out in https://bugzilla.mozilla.org/show_bug.cgi?id=1303096#c22, but somehow that comment was never addressed (partly my fault). We should probably base this off some other message, or maybe create a new message just for this purpose. I filed bug 1361939 for this.
Thanks for the explanation, makes sense!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: