Closed Bug 1304906 Opened 8 years ago Closed 8 years ago

GonkVideoDecoderManager.cpp:55:35: error: 'already_AddRefed<mozilla::layers::TextureClient> mozilla::GonkTextureClientAllocationHelper::Allocate(mozilla::layers::CompositableForwarder*)' marked override, but does not override

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: asppsa, Assigned: fabrice)

References

Details

Attachments

(1 file)

bug1304906.patch
(deleted), patch
nical
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160824215626

Steps to reproduce:

Taskcluster builds of B2G for Aries and Nexus 5 L are failing with the above error.  Mulet builds are not affected.

An example of a failed build is https://tools.taskcluster.net/task-inspector/#UWImB2iuTESnPcxZMDi95A/0
Blocks: 1245091
Status: UNCONFIRMED → NEW
Ever confirmed: true
Looks like the definition of ITextureClientAllocationHelper::Allocate has changed to take a TextureForwarder* instead of a CompositableForwarder*
Attached patch bug1304906.patch (deleted) — — Splinter Review 
Assignee: nobody → fabrice

        Attachment #8794056 -
        Flags: review?(nical.bugzilla)

        Attachment #8794056 -
        Flags: review?(nical.bugzilla) → review+

    
    

    
  
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14f806e86ee0
GonkVideoDecoderManager.cpp:55 build error r=nical

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/14f806e86ee0
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox52:
          --- → fixed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: