Closed
Bug 1304910
Opened 8 years ago
Closed 8 years ago
[e10s] URL.createObjectURL asserts if used with a blob backed by nsTemporaryFileInputStream
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: jdm, Assigned: baku)
References
Details
Attachments
(3 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
STR:
1. use MediaRecorder to grab video that exceeds media.recorder.max_memory bytes
2. call URL.createObjectURL on the resulting blob
The result in a debug build is a child process assertion that often takes down the browser process too. I'm not sure what happens in a non-debug build yet.
Reporter | ||
Comment 1•8 years ago
|
||
I discovered this while fixing bug 1167730, since solving the crash there exposes this assertion in a debug build on air.mozilla.org when uploading a recording.
Reporter | ||
Comment 2•8 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
I spent some time trying to figure out this code, but it's way outside my realm of experience and it's probably more efficient for people who know the blob code to figure out what the right solution is here.
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 4•8 years ago
|
||
Is this a duplicate of bug 1167730 ? If not I'll take a look when you cancel the NI request.
Flags: needinfo?(amarchesini) → needinfo?(josh)
Reporter | ||
Comment 5•8 years ago
|
||
No. This was uncovered by fixing bug 1167730.
Flags: needinfo?(josh)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → amarchesini
Assignee | ||
Comment 6•8 years ago
|
||
nsTemporaryFileInputStream must implement nsIAsyncInputStream interface.
Assignee | ||
Comment 7•8 years ago
|
||
This test now works. I guess it's because of bug 1167730. In that bug you make nsTemporaryFileStream a nsIIPCSerializableInputStream. This means that we change the workflow here:
https://dxr.mozilla.org/mozilla-central/source/ipc/glue/IPCStreamUtils.cpp#126
Attachment #8795193 -
Flags: review?(josh)
Reporter | ||
Comment 8•8 years ago
|
||
Huh, you're right. Air Mozilla works now too. I guess something about the second patch fixed it for some reason? It was definitely triggering with the first patch in bug 1167730 applied.
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8795193 [details] [diff] [review]
just a test
Review of attachment 8795193 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/media/test/mochitest.ini
@@ +929,5 @@
> [test_background_video_no_suspend_short_vid.html]
> tags = suspend
> [test_background_video_no_suspend_disabled.html]
> tags = suspend
> +[test_bug1304910.html]
Let's give this a real name like test_temporary_file_blob_video_plays.html.
Attachment #8795193 -
Flags: review?(josh) → review+
Comment 10•8 years ago
|
||
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78726bd7bb0b
Adding a test about nsTemporaryFileInputStream and PSendStream, r=jdm
Comment 11•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•