Open
Bug 1304997
Opened 8 years ago
Updated 4 years ago
Avoid race between UpdateBrowserIndicators and test code
Categories
(Firefox :: Site Permissions, defect, P3)
Firefox
Site Permissions
Tracking
()
NEW
People
(Reporter: pehrsons, Unassigned)
References
Details
See [1] and bug 1284102 for evidence of these races. I believe the race comes from [2]. The test waits for the same event that triggers this code, but this code needs another async event to update the state we are about to check.
Florian might know the details better.
[1] http://searchfox.org/mozilla-central/rev/8910ca900f826a9b714607fd23bfa1b37a191eca/browser/base/content/test/webrtc/head.js#91
[2] http://searchfox.org/mozilla-central/rev/8910ca900f826a9b714607fd23bfa1b37a191eca/browser/modules/ContentWebRTC.jsm#310
Reporter | ||
Comment 1•8 years ago
|
||
Comment from Florian on IRC on what should be done:
> [10:21:38] <flo-retina> in the future I think it would be nice to investigate if both of these
> timer-based hacks could be removed and replaced with something listening for the
> webrtc:UpdateBrowserIndicators message in the parent process.
Updated•4 years ago
|
Severity: normal → S4
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•