Closed Bug 1305381 Opened 8 years ago Closed 8 years ago

Font glyphs cut off at the top

Categories

(Core :: Graphics: Text, defect)

x86_64
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 - fixed

People

(Reporter: gcp, Unassigned)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image fontcut.png (deleted) —
Nightly, Windows 10, AMD Radeon R9 390, Crimson 16.9.2. This is a very recent regression.

See screenshot. The same behavior is visible on irccloud or even Bugzilla.

The first frame doesn't necessarily trigger this behavior, but it generally comes after scrolling a bit.
Even when fonts are not cut off as pictured, I have the impression they're being rendered too thin.
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Version: unspecified → Trunk
Attached image bugzilla.png (deleted) —
Here's it happening on Bugzilla.
I'm seeing this as well.
[Tracking Requested - why for this release]:
recent regression in nightly
 4:05.74 INFO: Last good revision: 2f21fdc94dcfb4635ed5218ea3d2dd43fb332d07
 4:05.74 INFO: First bad revision: aeb3209d58fee9d5ecce3832986acc81b7d720da
 4:05.74 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2f21fdc94dcfb4635ed5218ea3d2dd43fb332d07&tochange=aeb3209d58fee9d5ecce3832986acc81b7d720da

aeb3209d58fe	Matt Woodrow — Bug 1302918 - Remove old Compositor sharing code. r=nical
2b4457a0428b	Matt Woodrow — Bug 1302918 - Add PVideoBridge to share textures with the compositor. r=dvander,nical
cb3267d9e339	Matt Woodrow — Bug 1303897 - Part 3: Remove unnecessary param to InitIPDLActor. r=nical
0af32711ba65	Matt Woodrow — Bug 1303897 - Part 2: Use TextureForwarder for TextureClientRecycleAllocator. r=nical
11dff62f0ef5	Matt Woodrow — Bug 1303897 - Part 1: Use TextureForwarder for Image::GetTextureClient. r=nical
Are you sure about this regression range?

It seems very unlikely that this change affected text rendering. There were some glyph changes that went in at almost the same time, those seem much more likely.
It's always possible that I put a "good" in mozregression whereas it should've been a "bad".

That said, the odds of accidentally landing on a gfx change...
 3:22.38 INFO: Narrowed inbound regression window from [2f21fdc9, d343d428] (3 revisions) to [2f21fdc9, aeb3209d] (2 revisions) (~1 steps left)
 3:22.38 INFO: Oh noes, no (more) inbound revisions :(
 3:22.38 INFO: Last good revision: 2f21fdc94dcfb4635ed5218ea3d2dd43fb332d07
 3:22.38 INFO: First bad revision: aeb3209d58fee9d5ecce3832986acc81b7d720da
 3:22.39 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2f21fdc94dcfb4635ed5218ea3d2dd43fb332d07&tochange=aeb3209d58fee9d5ecce3832986acc81b7d720da

Exact same push on inbound. So yeah, I definitely blame you Matt :-)
Attached image font.png (deleted) —
I don't know if it's related but i'm seeing wonky pixel placement in general on nightly, not just the top being cut off.
Is this still happening?

I can see how it happened, and bug 1281456 should have fixed it.
This no longer occurs for me.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
No need to track based on Comment 11.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: