Closed
Bug 1305654
Opened 8 years ago
Closed 8 years ago
Fix the SetMaximum C++ API for Scalars
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
(deleted),
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
We should change the |SetValue|s highlighted in [1] to |SetMaximum|.
[1] - https://dxr.mozilla.org/mozilla-central/rev/c55bcb7c777ea09431b4d16903ed079ae5632648/toolkit/components/telemetry/TelemetryScalar.cpp#1700,1721
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8795180 -
Flags: review?(gfritzsche)
Updated•8 years ago
|
Attachment #8795180 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d044a6f7756c
Fix the SetMaximum C++ API for Scalars. r=gfritzsche
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•