Closed Bug 1305794 Opened 8 years ago Closed 8 years ago

Remove Cortana-related strings from mozilla-central

Categories

(Firefox :: Search, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: Felipe, Unassigned, Mentored)

References

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1287622 +++ Bug 1287622 removed the usage of the strings "redirectWindowsSearch.label" and "redirectWindowsSearch.accesskey", but they weren't removed from the tree.
Filipe, can you fix this?
Flags: needinfo?(bugzilla)
Hey Jared, what does it mean, removing from the tree?
Flags: needinfo?(bugzilla) → needinfo?(felipc)
Hi Filipe, here you can see that this label was removed: https://hg.mozilla.org/mozilla-central/rev/fd5453b8f5b8#l4.34 but the string that it refered too is still in the code, but now it's unused: http://searchfox.org/mozilla-central/rev/572e74ee991bbfd812766b4524237eb77577a4b1/browser/locales/en-US/chrome/browser/preferences/search.dtd#16 So you should remove these two strings from the search.dtd file
Flags: needinfo?(felipc)
(In reply to Filipe from comment #2) > Hey Jared, what does it mean, removing from the tree? "the tree" is just another name for mozilla-central :)
I've uploaded a new patch that also removes those strings in search.dtd. thanks for the help! :)
Flags: needinfo?(jaws)
Flags: needinfo?(jaws)
Attachment #8798044 - Flags: review?(felipc)
Comment on attachment 8798044 [details] [diff] [review] 0001-Bug-8791737-Remove-Cortana-related-code-from-Firefox.patch Thanks for the patch, Filipe. The change you made is correct, but it looks like the patch also included an unrelated change in browser/app/profile/firefox.js. Could you post a new patch that doesn't include that?
Attachment #8798044 - Flags: review?(felipc) → feedback+
Attachment #8813590 - Flags: review?(felipc)
Attachment #8813590 - Flags: feedback?(felipc)
Hi, I am new to this and looking for a simple first bug to fix, to help me get used to process of submitting bug fixes. I noticed that this has had no activity for over a month and was still open, so I have uploaded a patch. If this patch is ok, can I have this bug assigned to me? Thanks for any assistance
Flags: needinfo?(felipc)
Attachment #8813590 - Flags: review?(felipc)
Attachment #8813590 - Flags: review+
Attachment #8813590 - Flags: feedback?(felipc)
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff1755fa83c Remove Cortana-related strings from mozilla-central. r=felipe
Thanks everyone! I added both of your names in the commit message. https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff1755fa83c
Flags: needinfo?(felipc)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: