Closed
Bug 1305794
Opened 8 years ago
Closed 8 years ago
Remove Cortana-related strings from mozilla-central
Categories
(Firefox :: Search, defect, P4)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: Felipe, Unassigned, Mentored)
References
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(2 files)
(deleted),
patch
|
Felipe
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1287622 +++
Bug 1287622 removed the usage of the strings "redirectWindowsSearch.label" and "redirectWindowsSearch.accesskey", but they weren't removed from the tree.
Hey Jared, what does it mean, removing from the tree?
Flags: needinfo?(bugzilla) → needinfo?(felipc)
Reporter | ||
Comment 3•8 years ago
|
||
Hi Filipe,
here you can see that this label was removed: https://hg.mozilla.org/mozilla-central/rev/fd5453b8f5b8#l4.34
but the string that it refered too is still in the code, but now it's unused: http://searchfox.org/mozilla-central/rev/572e74ee991bbfd812766b4524237eb77577a4b1/browser/locales/en-US/chrome/browser/preferences/search.dtd#16
So you should remove these two strings from the search.dtd file
Flags: needinfo?(felipc)
Comment 4•8 years ago
|
||
(In reply to Filipe from comment #2)
> Hey Jared, what does it mean, removing from the tree?
"the tree" is just another name for mozilla-central :)
I've uploaded a new patch that also removes those strings in search.dtd. thanks for the help! :)
Flags: needinfo?(jaws)
Updated•8 years ago
|
Flags: needinfo?(jaws)
Updated•8 years ago
|
Attachment #8798044 -
Flags: review?(felipc)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8798044 [details] [diff] [review]
0001-Bug-8791737-Remove-Cortana-related-code-from-Firefox.patch
Thanks for the patch, Filipe. The change you made is correct, but it looks like the patch also included an unrelated change in browser/app/profile/firefox.js.
Could you post a new patch that doesn't include that?
Attachment #8798044 -
Flags: review?(felipc) → feedback+
Comment 8•8 years ago
|
||
Attachment #8813590 -
Flags: review?(felipc)
Attachment #8813590 -
Flags: feedback?(felipc)
Comment 9•8 years ago
|
||
Hi,
I am new to this and looking for a simple first bug to fix, to help me get used to process of submitting bug fixes.
I noticed that this has had no activity for over a month and was still open, so I have uploaded a patch. If this patch is ok, can I have this bug assigned to me?
Thanks for any assistance
Flags: needinfo?(felipc)
Reporter | ||
Updated•8 years ago
|
Attachment #8813590 -
Flags: review?(felipc)
Attachment #8813590 -
Flags: review+
Attachment #8813590 -
Flags: feedback?(felipc)
Comment 10•8 years ago
|
||
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff1755fa83c
Remove Cortana-related strings from mozilla-central. r=felipe
Reporter | ||
Comment 11•8 years ago
|
||
Thanks everyone! I added both of your names in the commit message.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff1755fa83c
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(felipc)
Comment 12•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•8 years ago
|
status-firefox52:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•