Closed Bug 1305831 Opened 8 years ago Closed 7 years ago

"LastPass might be making Nightly run slowly"

Categories

(Firefox :: Extension Compatibility, defect)

52 Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: znmeb, Unassigned)

References

Details

(Keywords: nightly-community)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20160927030200 Steps to reproduce: Install Nightly on Fedora 24 x86_64 Install LastPass addon Actual results: I get a bar at the bottom saying "LastPass might be making Nightly run slowly". I don't actually sense a slowdown. Note that I have e10s disabled. Expected results: No warnings.
I tried this with e10s enabled. TweetDeck became totally unresponsive and I ended up having to shut down Nightly with a force quit. So I have disabled LastPass and am still running with e10s. I think TweetDeck + LastPass + Nightly e10s is broken on Fedora 24 but don't have the tools to troubleshoot it right now.
You should make sure you are using Lastpass 4.1.26 https://lastpass.com/misc_download2.php the 3.x version on addons.mozilla.org is old and known to be quite slow.
(In reply to Kevin Brosnan [:kbrosnan] from comment #2) > You should make sure you are using Lastpass 4.1.26 > https://lastpass.com/misc_download2.php the 3.x version on > addons.mozilla.org is old and known to be quite slow. Hmmm ... I did have LastPass 3.3 ... trying LastPass 4.1.29a
Current status: 1. Fedora 24 x86_64 2. Nightly 52.0a1 (2016-09-27) (64-bit) 3. e10s enabled 4. TweetDeck and GMail Inbox in other tabs 5. LastPass 4.1.29a I see the warning again ... will attach screenshot Performance is glitchy at times but not a dead stop like other times. Nothing shows in "top" as hogging CPU So it's better but still an issue
Attached image screenshot of warning (deleted) —
OK ... now I almost have a smoking gun. e10s enabled, just one tab running TweetDeck. TweetDeck slowed to a crawl, "top" showed the "WebContent" process at 100%. So I disabled LastPass and things rapidly returned to normal.
Hello znmeb, I tried reproducing this issue on Fedora with the latest nightly Build ID 20160930030315 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 OS Linux 4.5.2-302.fc24.x86_64 I didn't encounter any performance issue with LastPass addon with e10s on. About:Performance info: Full name: support@lastpass.com. Impact on framerate: 4/10 (2 alerts). CPU usage: 2%. System usage: 1%. Blocking process calls: 0%. Measure start: 6324 seconds ago. Processes: 2448 (parent), 2497 (child) Here is the profile info https://cleopatra.io/#report=5139db6f2f47af1feeba2337df8b8c8a56e3d814 See https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Reporting_a_Performance_Problem May ask you to provide your about:performance info and check the browser console for any cpow error.
Component: Untriaged → Extension Compatibility
(needinfo for comment 7)
Flags: needinfo?(znmeb)
(In reply to Kanchan Kumari QA from comment #7) > Hello znmeb, I tried reproducing this issue on Fedora with the latest nightly > > Build ID 20160930030315 > User Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Firefox/52.0 > OS Linux 4.5.2-302.fc24.x86_64 > > I didn't encounter any performance issue with LastPass addon with e10s on. > About:Performance info: > Full name: support@lastpass.com. > Impact on framerate: 4/10 (2 alerts). > CPU usage: 2%. > System usage: 1%. > Blocking process calls: 0%. > Measure start: 6324 seconds ago. > Processes: 2448 (parent), 2497 (child) > > Here is the profile info > https://cleopatra.io/#report=5139db6f2f47af1feeba2337df8b8c8a56e3d814 > > See > https://developer.mozilla.org/en-US/docs/Mozilla/Performance/ > Reporting_a_Performance_Problem > > May ask you to provide your about:performance info and check the browser > console for any cpow error. https://cleopatra.io/#report=1d846d9c5b29e64ce0c9b8a9ed945c1ea1b25575
(In reply to znmeb from comment #9) > (In reply to Kanchan Kumari QA from comment #7) > > Hello znmeb, I tried reproducing this issue on Fedora with the latest nightly > > > > Build ID 20160930030315 > > User Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > > Firefox/52.0 > > OS Linux 4.5.2-302.fc24.x86_64 > > > > I didn't encounter any performance issue with LastPass addon with e10s on. > > About:Performance info: > > Full name: support@lastpass.com. > > Impact on framerate: 4/10 (2 alerts). > > CPU usage: 2%. > > System usage: 1%. > > Blocking process calls: 0%. > > Measure start: 6324 seconds ago. > > Processes: 2448 (parent), 2497 (child) > > > > Here is the profile info > > https://cleopatra.io/#report=5139db6f2f47af1feeba2337df8b8c8a56e3d814 > > > > See > > https://developer.mozilla.org/en-US/docs/Mozilla/Performance/ > > Reporting_a_Performance_Problem > > > > May ask you to provide your about:performance info and check the browser > > console for any cpow error. > > https://cleopatra.io/#report=1d846d9c5b29e64ce0c9b8a9ed945c1ea1b25575 about:performance is claiming LastPass is performing well. However, it is saying both TweetDeck and Google's Inbox are performing poorly. I can confirm the fact that both of them are really poor performers - Inbox in particular is very frustrating. I'm guessing they're using terrible JavaScript or doing way too much network data transfer and may be optimized for Chrome. I don't have any viable option besides TweetDeck, but I can drop back to the GMail user interface or even the raw HTML version of GMail to see if this goes away. My suspicion is that LastPass is fine and somehow Firefox is confusing its performance metrics with those of TweetDeck.
Andrei, can your team take a deeper look into performance of LastPass 4 + e10s on Win, Mac, and Linux? From talking with blassey and the e10s team today it sounds like we keep getting reports of performance issues and haven't pinned down the problems yet. If we can see the slowdown/CPU use increase and capture that in a profile it could help us fix this in the 52 beta timeframe. (Not for 51 obviously) Thanks.
Flags: needinfo?(andrei.vaida)
smaug, is there any specific testing advice or needs you have here?
Flags: needinfo?(bugs)
blassey would be better to answer to that, since I don't know STR. I was looking at a profile and it showed Lastpass is running tons of JS (like 5s pause), and I don't think they really need to do all that. All the callers of LP_createXPathFromElement are suspicious, the following is showing just one example https://new.cleopatra.io/public/acf31db74aeb29e1a04812f733eff55579d3fb2b/calltree/?range=13.7671_25.6784&search=LP_createXPathFromElement&thread=2
Flags: needinfo?(bugs) → needinfo?(blassey.bugs)
I'd suggest: * Install LastPass 4.x (the dev channel version in AMO) * Import your passwords into it * Test sites that take text input looking for slowness and capture a profile when it is slow (ex irccloud, google docs)
Flags: needinfo?(blassey.bugs)
I used 4.1.35 LastPass version with latest Nightly 54.0a1. I've never seen the notification bar with "LastPass might be making Nightly run slowly" message, but on about:performance tab, "LastPass may currently be slowing down Nightly." appears really often, even when opening/closing tabs. CPU usage here normally doesn't exceed 20%, but it was 70-80% once or twice. I tried to get a gecko profiler then, but I'm not sure it was registered. Below are the profilers for every OS. [:blassey] (use needinfo?) from comment #14) > * Test sites that take text input looking for slowness and capture a profile > when it is slow (ex irccloud, google docs) about:performance doesn't register performance problems with LastPass while doing text input on different sites. Win 10 64-bit: https://cleopatra.io/#report=3821bc140f765f18775ed63f89b36d342c3fee36 https://cleopatra.io/#report=14b0424ae3f99201757127eea7334419807f1b85 Ubuntu 16.04 LTS 64-bit: https://cleopatra.io/#report=96da27818b266cbb6e258a71873b4d70e3c3b48f Mac OS X 10.11: https://new.cleopatra.io/public/7b6b821c5090ccf4778e2bddfa2d66de54861f41/calltree/?thread=2(In reply to Brad Lassey Please let me know how I could help next.
Flags: needinfo?(andrei.vaida)
Depends on: 1334264
Hi Petruta, was the testing with e10s on or off? > I used 4.1.35 LastPass version with latest Nightly 54.0a1. > > I've never seen the notification bar with "LastPass might be making Nightly > run slowly" message, but on about:performance tab, "LastPass may currently > be slowing down Nightly." appears really often, even when opening/closing > tabs. CPU usage here normally doesn't exceed 20%, but it was 70-80% once or > twice. I tried to get a gecko profiler then, but I'm not sure it was > registered. Below are the profilers for every OS. > > [:blassey] (use needinfo?) from comment #14) > > * Test sites that take text input looking for slowness and capture a profile > > when it is slow (ex irccloud, google docs) > about:performance doesn't register performance problems with LastPass while > doing text input on different sites. > > Win 10 64-bit: > https://cleopatra.io/#report=3821bc140f765f18775ed63f89b36d342c3fee36 > > https://cleopatra.io/#report=14b0424ae3f99201757127eea7334419807f1b85 > Ubuntu 16.04 LTS 64-bit: > https://cleopatra.io/#report=96da27818b266cbb6e258a71873b4d70e3c3b48f > Mac OS X 10.11: > https://new.cleopatra.io/public/7b6b821c5090ccf4778e2bddfa2d66de54861f41/ > calltree/?thread=2(In reply to Brad Lassey > > Please let me know how I could help next.
Flags: needinfo?(petruta.rasa)
Hi Shell, e10s was enabled when I performed the testing.
Flags: needinfo?(petruta.rasa)
While anecdotal, I can confirm that LastPass' extension exhibited serious performance issues. I've experienced slowdowns for a couple years, at a minimum. Careful examination has repeatedly pointed to LastPass as the culprit for the slowdowns that I've experienced. This has been true not only for the extension's v3.x series but for the v4.x series as well, though, I will say that the latter implementation performs marginally better. Performance issues have been fairly constant across all versions of Firefox (up to and including the current nightlies), with and without e10s, and seems to be more or less independent of the extension's version.
Bug 1309946 removed "this addon might be making Firefox run slowly" warning.
Given all the other issues with LastPass, I've removed it from Firefox across the board.
Flags: needinfo?(znmeb)
Mass-closing old Extension Compatibility bugs that relate to legacy add-ons or NPAPI plug-ins. If you think this bug is still valid, please reopen or comment. Sorry for the bug spam, and happy Friday!
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: