Closed
Bug 1306445
Opened 8 years ago
Closed 7 years ago
Remove the mobile bookmarks anno from the mobile root
Categories
(Toolkit :: Places, defect, P1)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: lina, Assigned: standard8)
References
Details
Attachments
(1 file)
Once users have some time to migrate to the new mobile root (2-3 cycles after bug 1302901 lands), we can remove the anno, and the code from `BookmarkJSONUtils` to move mobile folder contents into the root.
Updated•8 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Priority: P3 → P2
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Marco, just a thought, should I combine this with bug 1444094 and save another round of migration? (Since I assume we'll want to make sure the old places/excludeFromBackup annotations have all been removed).
Flags: needinfo?(mak77)
Comment 4•7 years ago
|
||
Would it be risky if some profiles would reain this anno indefinitely, or just for some more time?
I'm mostly guessing if we could do the removal in maintenance, rather than on migration.
https://searchfox.org/mozilla-central/rev/b29daa46443b30612415c35be0a3c9c13b9dc5f6/toolkit/components/places/PlacesDBUtils.jsm#244
Migration should be used if having those around may cause a risk to the user's data, or if the orphans take a large chunk of space, off-hand it doesn't sound the case?
Flags: needinfo?(mak77)
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Marco Bonardo [::mak] from comment #4)
> Would it be risky if some profiles would reain this anno indefinitely, or
> just for some more time?
Discussing with Kit over irc, this annotation doesn't get synced, and there should only be one of them. Given that is one record in each of two tables, that doesn't seem too expensive. New profiles won't have it.
It also feels like having it in potentially daily maintenance isn't really necessary.
If in the future, we remove annotations, then we could drop it at that time, or if we find some other reason that we need to maintain the annotations table, we could drop it then.
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8960763 [details]
Bug 1306445 - Remove the mobile bookmarks annotation from the mobile root as it is no longer required.
https://reviewboard.mozilla.org/r/229506/#review235758
Attachment #8960763 -
Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f371354d1364
Remove the mobile bookmarks annotation from the mobile root as it is no longer required. r=mak
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•