Closed
Bug 1306834
Opened 8 years ago
Closed 8 years ago
Use 40 char SHAs in the hg.mozilla.org links to Treeherder
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: emorley, Assigned: gps)
References
Details
The hg.mozilla.org view for commits currently uses 12 character rather than 40 character SHAs in the links to Treeherder.
eg on:
https://hg.mozilla.org/mozilla-central/rev/af6e01b8574b
"[default view]" -> https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=87cd291d2db6
"[failures only]" -> https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=87cd291d2db6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
(the perfherder links on that page use 40 character SHAs however)
I'm presuming we just need to change:
{if(treeherderrepourl, if(pushhead, '<tr><td>treeherder</td><td>{treeherderrepo|escape}@{pushhead|short} [<a href="{treeherderrepourl}&revision={pushhead|short}">default view</a>] [<a href="{treeherderrepourl}&revision={pushhead|short}&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception">failures only]</td></tr>'))}
(in https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgtemplates/gitweb_mozilla/changeset.tmpl)
...to use '{pushhead}' instead of '{pushhead|short}'.
Also, I'm not sure why the Treeherder links are mostly defined in the template, whereas the Perfherder links are constructed fully in the hgmo extension instead?
Gregory, I don't suppose you could update this for us? (I don't have a testing environment set up etc, and I see several tests will need updating)
Thanks :-)
Flags: needinfo?(gps)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(gps)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a7eb2f1b2f6b
hgmo: use full hash when linking to Treeherder
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•8 years ago
|
||
Many thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•