Closed
Bug 1307132
Opened 8 years ago
Closed 8 years ago
cookies.js relies on AppConstants but is used from cookies.xul which does not import it at any point
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | unaffected |
| firefox50 | --- | unaffected |
| firefox51 | + | fixed |
| firefox52 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-review-board-request
|
jaws
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
Noticed on my nightly build that if you open the cookies dialog and hit a key, you get:
JavaScript error: chrome://browser/content/preferences/cookies.js, line 762: ReferenceError: AppConstants is not defined
This looks like a regression from bug 1294989
|
||
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]: regression introduced in v51
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
status-firefox49:
--- → unaffected
status-firefox50:
--- → unaffected
|
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8797193 [details]
Bug 1307132 - import AppConstants.jsm,
https://reviewboard.mozilla.org/r/82792/#review82520
Attachment #8797193 -
Flags: review?(jaws) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3ee1fa4da71b
import AppConstants.jsm, r=jaws
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 7•8 years ago
|
||
Hi :Gijs,
Since this bug is a regression and also affects 51, do you consider to uplift this for 51?
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8797193 [details]
Bug 1307132 - import AppConstants.jsm,
Approval Request Comment
[Feature/regressing bug #]: bug 1294989
[User impact if declined]: parts of the preferences' cookies dialog don't work correctly.
[Describe test coverage new/current, TreeHerder]: noooope, or we would have noticed earlier. I think the cookies dialog itself does have tests, just not once that noticed this breakage.
[Risks and why]: very low, effectively a 1-liner.
[String/UUID change made/needed]: nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8797193 -
Flags: approval-mozilla-aurora?
|
|
||
Comment 9•8 years ago
|
||
Comment on attachment 8797193 [details]
Bug 1307132 - import AppConstants.jsm,
Fix a regression. Take it in 51 aurora.
Attachment #8797193 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 10•8 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•