Closed Bug 1307178 Opened 8 years ago Closed 8 years ago

Build TilesClient module which is responsible for defining Tiles events and sending them for Activity Stream

Categories

(Firefox for iOS :: Telemetry, defect, P1)

Other
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.6

People

(Reporter: sleroux, Assigned: sleroux)

References

Details

(Whiteboard: [MobileAS])

Attachments

(2 files)

To collect these [1] metrics for Activity Stream, we'll need to build a small module that defines the various pings that we want to send an a network-backed client that sends them to the API server. Since this module has no dependencies to Firefox, I would recommend we build it as a small, separate framework that links into Firefox. [1] https://github.com/mozilla/activity-stream/blob/master/data_events.md
Priority: -- → P1
No longer blocks: 1298922
Blocks: 1307166
Patch for integrating telemetry into the AS Panel
Attachment #8800270 - Flags: review?(fpatel)
Attached file Onyx Client (deleted) —
The OnyxClient library that reports the events/sessions to the server. Currently FF is using the 0.0.2 but after review comments I can publish a 0.0.3 with fixes!
Attachment #8800273 - Flags: review?(fpatel)
Overall looks great. My only suggestions are related to simplifying the amount of code that is added to the ActivityStreamPanel.swift. If we can limit the amount of code there that would be awesome, makes things less noisy. The other suggestion I had was with putting all the telemetry related files into their own folder. Looks like there is already a Telemetry folder. lets add it in there? Also if you do this. It looks like there is a "ClientTelemetry.swift" in the root of the project. that should also be in the Telemetry folder.
Attachment #8800270 - Flags: review?(fpatel) → review+
Attachment #8800273 - Flags: review?(fpatel) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Iteration: --- → 1.6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: