Closed Bug 1307212 Opened 8 years ago Closed 8 years ago

19,700 instances of "getting z level of unregistered window" emitted from xpfe/appshell/nsWindowMediator.cpp during windows8-64 debug testing

Categories

(Core :: Window Management, defect)

Product:
Core
Component:
Window Management
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Stop warning about z-levels
(deleted), patch
froydnj
: review+
Details | Diff | Splinter Review
> 5036 WARNING: getting z level of unregistered window: file xpfe/appshell/nsWindowMediator.cpp, line 623 This warning [1] shows up in the following test suites: > 936 - W3C Web Platform Reftests Wr > 606 - Mochitest Other oth > 358 - Mochitest Browser Chrome bc1 > 352 - Mochitest Jetpack JP > 332 - Mochitest 5 > 316 - Mochitest Browser Chrome bc4 > 290 - Mochitest Browser Chrome bc5 > 212 - Mochitest Browser Chrome bc7 > 208 - Mochitest Browser Chrome bc3 > 156 - Mochitest 1 > 146 - Mochitest Clipboard cl > 136 - Mochitest 4 > 134 - Mochitest Browser Chrome bc6 > 126 - Mochitest 2 > 114 - Mochitest 3 > 110 - Mochitest Browser Chrome bc2 > 104 - Mochitest DevTools Browser Chrome dt1 > 76 - Mochitest DevTools Browser Chrome dt5 > 52 - Mochitest DevTools Browser Chrome dt7 > 40 - Mochitest DevTools Browser Chrome dt2 > 40 - Mochitest DevTools Browser Chrome dt4 > 34 - Mochitest DevTools Browser Chrome dt6 > 26 - Mochitest DevTools Browser Chrome dt8 > 24 - Mochitest Media mda > 16 - Mochitest GPU gpu > 16 - Mochitest DevTools Browser Chrome dt3 > 10 - Crashtest C > 10 - W3C Web Platform Tests 4 > 8 - Mochitest WebGL gl3 > 6 - JSReftest J > 6 - Reftest Unaccelerated Ru > 6 - Reftest R > 6 - W3C Web Platform Tests 5 > 4 - Mochitest WebGL gl1 > 4 - W3C Web Platform Tests 6 > 2 - W3C Web Platform Tests 10 > 2 - Mochitest WebGL gl2 > 2 - W3C Web Platform Tests 9 > 2 - W3C Web Platform Tests 8 > 2 - W3C Web Platform Tests 7 > 2 - W3C Web Platform Tests 3 > 2 - W3C Web Platform Tests 2 > 2 - W3C Web Platform Tests 1 It shows up in 1421 tests. A few of the most prevalent: > 788 - Shutdown > 174 - jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration > 112 - toolkit/components/prompts/test/test_modal_prompts.html > 48 - browser/base/content/test/general/browser_bug676619.js > 44 - dom/tests/browser/browser_test_new_window_from_content.js > 36 - dom/html/test/test_fullscreen-api.html > 36 - toolkit/components/passwordmgr/test/mochitest/test_prompt.html > 34 - toolkit/components/passwordmgr/test/test_prompt_async.html > 32 - toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js > 30 - browser/base/content/test/general/browser_newWindowDrop.js [1] https://hg.mozilla.org/mozilla-central/annotate/955840bfd3c2/xpfe/appshell/nsWindowMediator.cpp#l623
I get the feeling we can just remove this, there's already a reasonable explanation and it shows up most during Shutdown: > 623 NS_WARNING("getting z level of unregistered window"); > 624 // this goes off during window destruction
OS: All → Windows
Shows up a lot more often on win7-32: 19,700 instances of "getting z level of unregistered window" emitted from xpfe/appshell/nsWindowMediator.cpp during windows7-32-vm debug testing > 19736 WARNING: getting z level of unregistered window: file xpfe/appshell/nsWindowMediator.cpp, line 620 This warning [1] shows up in the following test suites: > 662 - W3C Web Platform Tests 1 > 648 - W3C Web Platform Tests e10s 1 > 546 - Mochitest e10s Browser Chrome bc5 > 526 - W3C Web Platform Tests 4 > 526 - W3C Web Platform Tests e10s 4 > 510 - W3C Web Platform Tests 7 > 504 - W3C Web Platform Tests e10s 7 > 486 - W3C Web Platform Tests 9 > 474 - W3C Web Platform Tests e10s 9 > 466 - Mochitest 5 > 464 - W3C Web Platform Tests 5 > 464 - W3C Web Platform Tests e10s 5 > 456 - Mochitest e10s Browser Chrome bc3 > 438 - W3C Web Platform Tests 8 > 438 - Mochitest Browser Chrome bc6 > 438 - W3C Web Platform Tests e10s 8 > 432 - W3C Web Platform Tests e10s 2 > 426 - W3C Web Platform Tests 6 > 426 - W3C Web Platform Tests 3 > 426 - W3C Web Platform Tests e10s 6 > 422 - Mochitest e10s 5 > 414 - W3C Web Platform Tests e10s 3 > 412 - Mochitest Browser Chrome bc2 > 410 - Mochitest Browser Chrome bc5 > 408 - W3C Web Platform Tests 2 > 400 - Mochitest e10s Browser Chrome bc6 > 378 - W3C Web Platform Tests 10 > 378 - W3C Web Platform Tests e10s 10 > 366 - Mochitest Browser Chrome bc1 > 356 - Mochitest Browser Chrome bc4 > 352 - Mochitest Jetpack JP > 350 - Mochitest e10s Browser Chrome bc4 > 336 - Mochitest e10s Browser Chrome bc7 > 322 - Mochitest e10s Browser Chrome bc1 > 272 - Mochitest Browser Chrome bc7 > 272 - Mochitest 1 > 250 - Mochitest e10s Browser Chrome bc2 > 248 - Mochitest e10s 1 > 244 - Mochitest 3 > 242 - Mochitest 4 > 238 - Mochitest 2 > 230 - Mochitest Browser Chrome bc3 > 230 - Mochitest e10s 4 > 230 - Mochitest e10s 2 > 228 - W3C Web Platform Reftests Wr > 210 - W3C Web Platform Reftests e10s Wr-e10s > 202 - Mochitest e10s 3 > 146 - Mochitest e10s DevTools Browser Chrome dt6 > 132 - Mochitest DevTools Browser Chrome dt5 > 98 - Mochitest DevTools Browser Chrome dt4 > 94 - Mochitest e10s DevTools Browser Chrome dt1 > 92 - Mochitest DevTools Browser Chrome dt1 > 86 - Mochitest e10s DevTools Browser Chrome dt7 > 78 - Mochitest DevTools Browser Chrome dt3 > 70 - Mochitest e10s DevTools Browser Chrome dt5 > 60 - Mochitest Media mda > 60 - Mochitest DevTools Browser Chrome dt2 > 54 - Mochitest e10s DevTools Browser Chrome dt4 > 52 - Mochitest e10s DevTools Browser Chrome dt2 > 50 - Mochitest DevTools Browser Chrome dt8 > 48 - Mochitest a11y a11y > 44 - Mochitest e10s GPU gpu > 44 - Mochitest GPU gpu > 36 - Mochitest e10s DevTools Browser Chrome dt8 > 36 - Mochitest DevTools Browser Chrome dt7 > 24 - Mochitest WebGL gl3 > 24 - Mochitest e10s WebGL gl3 > 24 - Mochitest DevTools Browser Chrome dt6 > 16 - Crashtest e10s C > 16 - Mochitest e10s DevTools Browser Chrome dt3 > 16 - Crashtest C > 12 - Mochitest WebGL gl1 > 12 - Mochitest e10s WebGL gl1 > 10 - Reftest Unaccelerated e10s Ru1 > 10 - Reftest Unaccelerated e10s Ru2 > 10 - JSReftest J2 > 10 - JSReftest J1 > 10 - Reftest e10s R-e10s2 > 10 - JSReftest e10s J1 > 10 - JSReftest e10s J2 > 10 - Reftest e10s R-e10s1 > 10 - Reftest R1 > 10 - Reftest Unaccelerated Ru1 > 10 - Reftest Unaccelerated Ru2 > 10 - Reftest GPU e10s Rg > 6 - Mochitest WebGL gl2 > 6 - Reftest R2 > 6 - Mochitest e10s WebGL gl2 It shows up in 2950 tests. A few of the most prevalent: > 2122 - Shutdown > 2122 - [e10s] Shutdown > 166 - jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration > 112 - toolkit/components/prompts/test/test_modal_prompts.html > 108 - [e10s] toolkit/components/prompts/test/test_modal_prompts.html > 48 - browser/base/content/test/general/browser_bug676619.js > 48 - [e10s] browser/base/content/test/general/browser_bug676619.js > 44 - [e10s] dom/tests/browser/browser_test_new_window_from_content.js > 44 - dom/tests/browser/browser_test_new_window_from_content.js > 40 - [e10s] dom/html/test/test_fullscreen-api.html [1] https://hg.mozilla.org/mozilla-central/annotate/c800b6dfca67/xpfe/appshell/nsWindowMediator.cpp#l620
Summary: 5,000 instances of "getting z level of unregistered window" emitted from xpfe/appshell/nsWindowMediator.cpp during windows8-64 debug testing → 19,700 instances of "getting z level of unregistered window" emitted from xpfe/appshell/nsWindowMediator.cpp during windows8-64 debug testing
Attached patch Stop warning about z-levels (deleted) — — Splinter Review
It's not clear who should review this, the code is from circa 2003. I considered making the function return a failure code but none of the callers check the current return value. Nathan can you take a look or maybe help me redirect?
Attachment #8869621 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Component: General → Window Management
Comment on attachment 8869621 [details] [diff] [review] Stop warning about z-levels Review of attachment 8869621 [details] [diff] [review]: ----------------------------------------------------------------- Sure, let's just do this.
Attachment #8869621 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/76e550bb72f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: