Closed Bug 1307223 Opened 8 years ago Closed 8 years ago

6,600 instances of "NS_ENSURE_TRUE(SUCCEEDED(hr)) failed" emitted from dom/media/platforms/wmf/WMFUtils.cpp during windowsxp debug testing

Categories

(Core :: Audio/Video: Playback, defect, P5)

Product:
Core
Component:
Audio/Video: Playback
Platform:
All
Windows
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1307223 - Don't warning multiple times about WMF dlls failing to load.
(deleted), text/x-review-board-request
cpearce
: review+
Details
> 6625 WARNING: NS_ENSURE_TRUE(SUCCEEDED(hr)) failed: file dom/media/platforms/wmf/WMFUtils.cpp, line 206 This warning [1] shows up in the following test suites: > 2537 - Mochitest Media mda > 603 - Reftest R > 445 - W3C Web Platform Reftests Wr > 435 - Crashtest C > 348 - W3C Web Platform Tests 4 > 335 - Mochitest Other oth > 328 - W3C Web Platform Tests 6 > 134 - Mochitest Clipboard cl > 127 - Mochitest 1 > 114 - Mochitest 3 > 111 - Mochitest Browser Chrome bc3 > 111 - Mochitest 5 > 97 - Mochitest 4 > 90 - Mochitest 2 > 83 - W3C Web Platform Tests 3 > 78 - Mochitest WebGL gl3 > 56 - Mochitest Browser Chrome bc4 > 54 - Mochitest Browser Chrome bc2 > 52 - Mochitest Browser Chrome bc5 > 52 - Mochitest Browser Chrome bc6 > 46 - Mochitest Browser Chrome bc1 > 46 - Mochitest GPU gpu > 40 - Mochitest WebGL gl1 > 37 - Mochitest DevTools Browser Chrome dt5 > 33 - Mochitest Browser Chrome bc7 > 30 - Mochitest DevTools Browser Chrome dt7 > 26 - Mochitest DevTools Browser Chrome dt6 > 23 - Mochitest DevTools Browser Chrome dt3 > 23 - Mochitest DevTools Browser Chrome dt1 > 18 - Mochitest DevTools Browser Chrome dt2 > 16 - Mochitest DevTools Browser Chrome dt4 > 16 - W3C Web Platform Tests 2 > 13 - W3C Web Platform Tests 9 > 13 - W3C Web Platform Tests 5 > 11 - Mochitest DevTools Browser Chrome dt8 > 11 - W3C Web Platform Tests 8 > 10 - Mochitest Jetpack JP > 5 - W3C Web Platform Tests 10 > 5 - Mochitest WebGL gl2 > 5 - W3C Web Platform Tests 7 > 5 - W3C Web Platform Tests 1 > 3 - JSReftest J It shows up in 872 tests. A few of the most prevalent: > 1185 - Shutdown > 400 - file:///C:/slave/test/build/tests/reftest/tests/dom/media/test/crashtests/691096-1.html > 143 - dom/media/test/test_media_selection.html > 129 - dom/media/test/test_load.html > 123 - dom/media/test/test_playback.html > 119 - dom/media/test/test_reset_src.html > 116 - /html/semantics/embedded-content/media-elements/mime-types/canPlayType.html > 108 - dom/media/test/test_fragment_noplay.html > 77 - dom/media/test/test_played.html > 60 - dom/media/test/test_can_play_type_mpeg.html [1] https://hg.mozilla.org/mozilla-central/annotate/955840bfd3c2/dom/media/platforms/wmf/WMFUtils.cpp#l206
This warning was introduced in bug 1174055, I'm not sure how long it has been triggering.
Blocks: 1174055
OS: All → Windows
LoadDLLs() in wmf::MFStartup() is expected to fail on Windows XP because XP doesn't have the WMF DLLs. On later versions of Windows, we do not expect it to fail. So if this logging is a problem, you could convert it to an NS_WARNING that only fires on Windows > XP.
Component: Audio/Video → Audio/Video: Playback
Priority: -- → P5
(In reply to Chris Pearce (:cpearce) from comment #2) > LoadDLLs() in wmf::MFStartup() is expected to fail on Windows XP because XP > doesn't have the WMF DLLs. On later versions of Windows, we do not expect it > to fail. So if this logging is a problem, you could convert it to an > NS_WARNING that only fires on Windows > XP. Sounds reasonable, do we have any utilities in tree to detect Windows > XP?
Flags: needinfo?(cpearce)
Looks like we've got it in mfbt [1]. [1] https://dxr.mozilla.org/mozilla-central/rev/955840bfd3c20eb24dd5a01be27bdc55c489a285/mfbt/WindowsVersion.h#144
Flags: needinfo?(cpearce)
Comment on attachment 8797276 [details] Bug 1307223 - Don't warning multiple times about WMF dlls failing to load. https://reviewboard.mozilla.org/r/82872/#review81520
Attachment #8797276 - Flags: review?(cpearce) → review+
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf226dd7668c Don't warning multiple times about WMF dlls failing to load. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/bf226dd7668c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: