Open
Bug 1307238
Opened 8 years ago
Updated 2 years ago
Remove B2G code from media playback code
Categories
(Core :: Audio/Video: Playback, defect, P5)
Core
Audio/Video: Playback
Tracking
()
NEW
People
(Reporter: cpearce, Unassigned)
References
(Blocks 1 open bug)
Details
Mozilla has announced that we're removing B2G code from mozilla-central.
https://groups.google.com/forum/#!topic/mozilla.dev.fxos/FoAwifahNPY
As such, we can now remove B2G specific code from the media playback code.
Off the top of my head, that would mean removing:
Everything inside a #ifdef MOZ_WIDGET_GONK block:
http://searchfox.org/mozilla-central/search?q=MOZ_WIDGET_GONK&path=dom%2Fmedia%2F
(excepting WebRTC code there)
Everything inside a #ifdef MOZ_OMX_DECODER block:
http://searchfox.org/mozilla-central/search?q=MOZ_OMX_DECODER&path=dom%2Fmedia%2F
MOZ_OMX_DECODER
And the Gonk PDM if that's not included in the above.
Cleaning up the audio channel will happen in bug 1299390.
Reporter | ||
Comment 1•8 years ago
|
||
Blake: Would you like to find someone on your team to do the honours here?
Flags: needinfo?(bwu)
Comment 2•8 years ago
|
||
What about the OMX Reader?
I think we should leave the OMX PDM. Without it it would be impossible to make an embedded version of Firefox (like on the very popular raspberry Pi)
Comment 3•8 years ago
|
||
raspberry Pi runs Debian, right?
Comment 4•8 years ago
|
||
It's one of the distribution available. But the only way they could properly play h264 is using the OMX hardware decoder.
Comment 5•8 years ago
|
||
(In reply to Jean-Yves Avenard [:jya] from comment #2)
> What about the OMX Reader?
>
> I think we should leave the OMX PDM. Without it it would be impossible to
> make an embedded version of Firefox (like on the very popular raspberry Pi)
Just now I'm trying to use it for embedded devices at bug1306529.
Please keep the code!
Reporter | ||
Comment 6•8 years ago
|
||
We can keep the OMX PDM if it means Raspberry Pi will use it. The rest, like the legacy Readers should go.
Updated•8 years ago
|
Comment 7•8 years ago
|
||
I am not sure if OMX PDM still uses some B2G graphics buffer or not. If yes, maybe we cannot keep it. I could be wrong. Ni the author!
Flags: needinfo?(bwu) → needinfo?(ayang)
Comment 8•8 years ago
|
||
If community needs it, maybe it's worth to be kept. However, you can remove GonkOmxPlatformLayer, it is the implementation for b2g only.
Flags: needinfo?(ayang)
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•