Closed
Bug 1307331
Opened 8 years ago
Closed 8 years ago
Use MOZ_MUST_USE in netwerk/protocol/data
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: wcpan, Assigned: wcpan)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
Subtask of bug 1303701.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8797395 [details]
Bug 1307331 - Use MOZ_MUST_USE in netwerk/protocol/data
https://reviewboard.mozilla.org/r/83000/#review81688
::: netwerk/ipc/NeckoParent.cpp:418
(Diff revision 1)
> bool
> NeckoParent::RecvPDataChannelConstructor(PDataChannelParent* actor,
> const uint32_t& channelId)
> {
> DataChannelParent* p = static_cast<DataChannelParent*>(actor);
> - p->Init(channelId);
> + return p->Init(channelId);
DataChannelParent::Init currently always returns true, but may not always be the case, and it might be difficult to debug if that changes.
Let's do MOZ_DIAGNOSTIC_ASSERT(p->Init(channelId)); and return true;
|
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8797395 [details]
Bug 1307331 - Use MOZ_MUST_USE in netwerk/protocol/data
https://reviewboard.mozilla.org/r/83000/#review81692
Looks good with only one nit.
Attachment #8797395 -
Flags: review?(valentin.gosu) → review+
|
|
||
Updated•8 years ago
|
Whiteboard: [necko-active]
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 5•8 years ago
|
||
Pushed by wpan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbc29ba0397b
Use MOZ_MUST_USE in netwerk/protocol/data r=valentin
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•