Closed
Bug 1307461
Opened 8 years ago
Closed 8 years ago
Intermittent mediapipeline_unittest | test failed with return code 1 due to MediaPipelineTest.TestAudioSendMux failure
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: intermittent-bug-filer, Assigned: dminor)
References
Details
(Keywords: intermittent-failure)
Attachments
(3 files)
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
Filed by: rvandermeulen [at] mozilla.com
https://treeherder.mozilla.org/logviewer.html#?job_id=3734995&repo=mozilla-aurora
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-aurora-linux-pgo/1475547840/mozilla-aurora_ubuntu32_vm_test_pgo-cppunit-bm05-tests1-linux32-build2.txt.gz
[ RUN ] MediaPipelineTest.TestAudioSendMux
/builds/slave/m-aurora-lx-000000000000000000/build/src/media/webrtc/signaling/test/mediapipeline_unittest.cpp:453: Failure
Value of: p2_.GetAudioRtpCountReceived()
Actual: 233
Expected: p1_.GetAudioRtpCountSent()
Which is: 970
[ FAILED ] MediaPipelineTest.TestAudioSendMux (11146 ms)
Updated•8 years ago
|
status-firefox51:
--- → affected
Updated•8 years ago
|
status-firefox52:
--- → affected
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 9•8 years ago
|
||
We stopped building this test on trunk via bug 1322707. However, 52 continues to be affected (and is destined to be our next ESR).
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Depends on: 1322707
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 10•8 years ago
|
||
If disabling the entire test isn't desirable, can we maybe skip just the one problematic subtest?
Flags: needinfo?(rjesup)
Comment 11•8 years ago
|
||
Dan, can you look at this? thanks
Flags: needinfo?(rjesup) → needinfo?(dminor)
Assignee | ||
Comment 12•8 years ago
|
||
Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=44a5cb4d2f19833bbf70f0e044259afac8bb4858
Flags: needinfo?(dminor)
Attachment #8831749 -
Flags: review?(rjesup)
Updated•8 years ago
|
Attachment #8831749 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8831749 [details] [diff] [review]
Disable TestAudioSendMux
Approval Request Comment
[Feature/Bug causing the regression]: Not sure, we're working around an intermittent failure.
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: This test is completely disabled in aurora and nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: We're disabling an intermittent test. There is a slight risk that we could introduce a regression that this test would have caught, but since this test is disabled on aurora and currently disabled on nightly while it is being rewrittent, I think we're ok with that risk.
[String changes made/needed]: None
Attachment #8831749 -
Flags: approval-mozilla-beta?
Comment 14•8 years ago
|
||
Comment on attachment 8831749 [details] [diff] [review]
Disable TestAudioSendMux
test-only changes don't need approval, thanks Dan!
Attachment #8831749 -
Flags: approval-mozilla-beta?
Updated•8 years ago
|
Whiteboard: [checkin-needed-beta]
Comment 15•8 years ago
|
||
bugherder uplift |
Whiteboard: [checkin-needed-beta]
Comment 16•8 years ago
|
||
Bah, it just moved to TestAudioSendNoMux. Guess that's not surprising given bug 1317044, in retrospect.
https://treeherder.mozilla.org/logviewer.html#?job_id=73368952&repo=mozilla-beta
Assignee: nobody → dminor
Flags: needinfo?(dminor)
Assignee | ||
Comment 17•8 years ago
|
||
If we see any more problems after this, I'll just disable the test completely.
Flags: needinfo?(dminor)
Attachment #8832505 -
Flags: review?(rjesup)
Updated•8 years ago
|
Attachment #8832505 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: checkin-needed-beta
Comment 18•8 years ago
|
||
Bug resolution tracks status on trunk.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Comment 19•8 years ago
|
||
bugherder uplift |
Updated•8 years ago
|
Whiteboard: checkin-needed-beta
Assignee | ||
Comment 20•8 years ago
|
||
New failure: https://treeherder.mozilla.org/logviewer.html#?job_id=75172990&repo=mozilla-beta&lineNumber=2625
Flags: needinfo?(dminor)
Assignee | ||
Comment 21•8 years ago
|
||
Just disable the test completely. Ryan said he would be willing to take the gtest version of this test once it is ready if it ends up being less prone to intermittent failures.
Flags: needinfo?(dminor)
Attachment #8835499 -
Flags: review?(rjesup)
Updated•8 years ago
|
Attachment #8835499 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•8 years ago
|
Whiteboard: checkin-needed-beta
Comment 22•8 years ago
|
||
bugherder uplift |
Whiteboard: checkin-needed-beta
Comment 23•8 years ago
|
||
bugherder uplift |
status-firefox-esr52:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•