Paul Adenot (:padenot) Assignee
	Description • 8 years ago

      No description provided.

	Matthew Gregan [:kinetik]
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8797954 [details]
Bug 1307724 - Cherry-pick cubeb revision 50d92c.

https://reviewboard.mozilla.org/r/83558/#review82148

::: media/libcubeb/src/cubeb_wasapi.cpp:512
(Diff revision 1)
>  
>    /* If this is not true, there will be glitches.
>       It is alright to have produced less frames if we are draining, though. */
>    XASSERT(out_frames == output_frames_needed || stm->draining || !has_output(stm));
>  
> +

Accidental extra newline here? (and it's not in the patch)

::: media/libcubeb/wasapi-stereo-mic.patch:5
(Diff revision 1)
> +From 50d92c0eaa05a93f4dd8ff5072e983c6c84d0369 Mon Sep 17 00:00:00 2001
> +From: Paul Adenot <paul@paul.cx>
> +Date: Tue, 4 Oct 2016 07:18:04 -0700
> +Subject: [PATCH] Divide by the number of channel of the stream to compute the
> + duratio of the buffer.

Typo: duration

	Matthew Gregan [:kinetik]
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8797954 [details]
Bug 1307724 - Cherry-pick cubeb revision 50d92c.

https://reviewboard.mozilla.org/r/83560/#review82150

r+ with nits

	Pulsebot
	Comment 4 • 8 years ago

Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6732c97395e
Cherry-pick cubeb revision 50d92c. r=kinetik

	Carsten Book [:Tomcat]
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d6732c97395e

	Maire Reavy [:mreavy]
	Comment 6 • 8 years ago

The patch for this bug resolved the bug in Bug 1300650.  

Paul -- We should uplift the patch here to Aurora or disable full duplex in Aurora.  Thanks.

	Paul Adenot (:padenot) Assignee
	Comment 7 • 8 years ago

Maire, this is already on aurora, https://bugzilla.mozilla.org/show_bug.cgi?id=1310206#c7