Closed Bug 1307746 Opened 8 years ago Closed 8 years ago

Make stack capturing thread-safe

Categories

(Toolkit :: Telemetry, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- fixed

People

(Reporter: gfritzsche, Assigned: yarik.sheptykin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

We'll need to make stack capturing thread-safe. This probably means to have a dedicated mutex & locking around stack capture invocations & data access.
Looking over this, we already mostly protect the shared data in `KeyedStackCapturer`. KeyedStackCapturer::Capture() doesn't protect all the data accesses yet though.
Assignee: nobody → yarik.sheptykin
Status: NEW → ASSIGNED
Attachment #8833370 - Flags: review?(gfritzsche) → review+
Hi Georg! I triggered a try build for this patch here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=176159b91df2&selectedJob=74796902 Some tests failed but they seem unrelated. For some reason I cannot re-trigger the jobs and cannot login either with LDAP or mozillian accounts. Can you re-trigger the tests that failed?
Flags: needinfo?(gfritzsche)
Those test failures look unrelated, i've triggered autoland.
Flags: needinfo?(gfritzsche)
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/autoland/rev/d185a8dc4c45 Make capturing stacks thread safe. r=gfritzsche
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Is this something that should go in 53 or is it going to ride the trains?
Flags: needinfo?(yarik.sheptykin)
Not sure about that, but :gfritzsche should know what is best.
Flags: needinfo?(yarik.sheptykin) → needinfo?(gfritzsche)
There is no code shipping in 53 that uses it, so there is no uplift needed.
Flags: needinfo?(gfritzsche)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: