Closed
Bug 1307788
Opened 8 years ago
Closed 8 years ago
Implement a Developer Tools notification when changes are applied
Categories
(Web Compatibility :: Interventions, defect)
Web Compatibility
Interventions
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: denschub, Assigned: etsai)
References
Details
Attachments
(1 file)
We need a way to inform site developers (and WebCompat debuggers) that we've applied changes, like User Agent overrides.
Reporter | ||
Comment 1•8 years ago
|
||
Implement a "The user agent has been overridden for compatibility reasons. [learn more]" with a link to the webcompat.com/bugzilla report.
Also, we need to figure out if it's possible to add two links: one for the actual report, one to instructions on how to disable that.
Assignee | ||
Comment 2•8 years ago
|
||
Base on the description in https://developer.mozilla.org/zh-TW/docs/Tools/Web_Console/Custom_output to implement a patch for notification.
QA Contact: etsai
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → etsai
QA Contact: etsai
Assignee | ||
Comment 3•8 years ago
|
||
Hi Dennis, this is my working patch for DevTool implement. Learn more is not possible but we can customize to enrich the notification.
Attachment #8806262 -
Flags: review?(dschubert)
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8806262 [details]
WIP for Implement DevTool notification
There seems to be no better way than the webextension solution Eric built at the moment. I am still working on getting information about what exactly needs to be implemented in Gecko for us to be able to do nicer logging, but let's not block on that.
Cancelling the review because of the style issues, but the general approach seems to be r+'ish.
Attachment #8806262 -
Flags: review?(dschubert) → review-
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8806262 [details]
WIP for Implement DevTool notification
I intended to cancel the review, not r- it. Sorry.
Attachment #8806262 -
Flags: review-
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8806262 [details]
WIP for Implement DevTool notification
Fix most eslint style and host permission to <all_urls>
Attachment #8806262 -
Flags: review?(dschubert)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8806262 [details]
WIP for Implement DevTool notification
r+! We're going to have a chat about possible follow-ups soon'ish, but this is great for now. Thanks for your work, Eric. :)
Attachment #8806262 -
Flags: review?(dschubert) → review+
Reporter | ||
Comment 8•8 years ago
|
||
Eric, could you please rebase on latest master?
Reporter | ||
Updated•8 years ago
|
Reporter | ||
Comment 9•8 years ago
|
||
I've merged this and opened bug 1316668 as a follow-up for improvements we should do in version 2! Thanks again, Eric!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•