Closed
Bug 1307792
Opened 8 years ago
Closed 8 years ago
Implement a way to disable all site patches
Categories
(Web Compatibility :: Interventions, defect)
Web Compatibility
Interventions
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: denschub, Assigned: denschub)
References
Details
Attachments
(1 file)
We need a way to disable specific or all site patches, so developers and WebCompat testers (and, FWIW, test suites) are able to test the raw site.
Also, we need to discuss if we need a UI to disable specific patches or if it's good enough to have a preference to disable everything.
Assignee | ||
Comment 1•8 years ago
|
||
Also, we need to think about whether disabling patches should be permanent or if everything should be disabled after a browser restart.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dschubert
Assignee | ||
Comment 2•8 years ago
|
||
Eric,
I implemented a basic preference called `extensions.webcompat.perform_ua_overrides` to turn all overrides off. As discussed, this resets on every browser start.
Attachment #8803270 -
Flags: review?(etsai)
Comment 3•8 years ago
|
||
Comment on attachment 8803270 [details]
PR to implement a preference to turn everything off
Please see my comments in PR.
Attachment #8803270 -
Flags: review?(etsai) → review-
Comment 4•8 years ago
|
||
Comment on attachment 8803270 [details]
PR to implement a preference to turn everything off
Thanks for fixing the observer.
Attachment #8803270 -
Flags: review- → review+
Assignee | ||
Comment 5•8 years ago
|
||
r+ from Eric as discussed per email[0]. If we run into troubles for forcing the pref to true when merging it into central, we can reconsider this decision, but for now, this is fine.
[0]: https://groups.google.com/forum/#!topic/mozilla.compatibility/tlwuFzZfz2o
Assignee | ||
Comment 6•8 years ago
|
||
Merged.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
No longer blocks: gofaster
Summary: Implement a way to disable all/specific site patches → Implement a way to disable all site patches
You need to log in
before you can comment on or make changes to this bug.
Description
•