Closed
Bug 1308083
Opened 8 years ago
Closed 8 years ago
Repair or remove "fix it" hyperlink
Categories
(SeaMonkey :: Website, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RainerBielefeldNG, Assigned: TheLayman)
References
(Blocks 1 open bug, )
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
TheLayman
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
On "Get Involved with SeaMonkey" you find "fix it" with a link to <http://www.mozilla.org/developer/> behind it.
Instead of useful hints I see a localized "Not Found" hint.
I haven't a clue whether there is a successor for <http://www.mozilla.org/developer/>. Vanished contents might be somewhere in the area of
<http://www-archive.mozilla.org/contribute/>
<http://www-archive.mozilla.org/developer/>
NEW due to Bug 1224107 comment #3
Comment 1•8 years ago
|
||
http://web.archive.org/web/20120503231604/http://www.mozilla.org/developer/
So http://www.mozilla.org/developer/ could be linked to https://developer.mozilla.org/docs/Mozilla/Developer_guide
But the "fix it" link on the Get Involved with SeaMonkey page could be simply linked to http://www.seamonkey-project.org/dev/
Comment 2•8 years ago
|
||
Hi,
Can anyone assign this thing to me? I am looking for my first contribution.
Thanks
Mayank Chauhan
Reporter | ||
Comment 3•8 years ago
|
||
No need to assign, you can simply start. I will send some hints by private mail
Comment 4•8 years ago
|
||
How I can get the code of the SeaMonkey site? So I can apply, what is written in comment #1.
Comment 5•8 years ago
|
||
On "Get Involved with SeaMonkey" these is "fix it" with a link to http://www.mozilla.org/developer/ .
Now, that link no longer exist. The correct link is
http://www.seamonkey-project.org/dev/ .
The link is now fixed.
Attachment #8821564 -
Flags: review?(RainerBielefeldNG)
Attachment #8821564 -
Flags: feedback?(RainerBielefeldNG)
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8821564 [details] [diff] [review]
Fixed the broken link, by replacing with correct one
I am not a developer and not a reviewer.
Feedback: <http://www.seamonkey-project.org/dev/> is a vaild link, but I would prefer Kohei Yoshino's suggestion of a direct link to <https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide> instead of detour to general overview "seamonkey-project.org/dev/", where .../Developer_guide also is linked.
@Jens: I read that you do not want to be reviewer in future. Is there any way to switch off BZ suggestion for "jh@junetz.de"?
Attachment #8821564 -
Flags: review?(jh)
Attachment #8821564 -
Flags: review?(RainerBielefeldNG)
Attachment #8821564 -
Flags: feedback?(RainerBielefeldNG)
Updated•8 years ago
|
Attachment #8821564 -
Flags: review?(jh) → review?(iann_bugzilla)
Comment 7•8 years ago
|
||
Comment on attachment 8821564 [details] [diff] [review]
Fixed the broken link, by replacing with correct one
I set the review? to IanN. Usually he or Philip Chee handle the reviews.
I agree with Rainer. Its likely you already came from the page which you now link to. I would put the Mzilla url in.
For an additional enhancement I would also add a small explanation together with the link. Clicking on fix it and redirecting to a generic dev page is a little bland.
FRG
Attachment #8821564 -
Flags: feedback+
Updated•8 years ago
|
Attachment #8821564 -
Flags: feedback+
Comment 8•8 years ago
|
||
@Frank-Rainer Grahl
I have made the changes, as you wished. Is the fine now?
Comment 9•8 years ago
|
||
Attachment #8821564 -
Attachment is obsolete: true
Attachment #8821564 -
Flags: review?(iann_bugzilla)
Attachment #8821711 -
Flags: review?(iann_bugzilla)
Comment 11•8 years ago
|
||
Comment on attachment 8821711 [details] [diff] [review]
Replaced the wrong link in fix it with new link
Not sure where you are getting the source file from. According to https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/file/tip/src/dev/get-involved.en.html#l67 it doesn't seem to be the same version.
Did you use https://hg.mozilla.org/SeaMonkey/seamonkey-project-org ?
Whilst you are here could you remove the extra space from the line above?
f=me for the moment as need new patch against correct source.
Attachment #8821711 -
Flags: review?(iann_bugzilla) → feedback+
Comment 12•8 years ago
|
||
(In reply to Ian Neal from comment #11)
> Comment on attachment 8821711 [details] [diff] [review]
> Replaced the wrong link in fix it with new link
>
> Not sure where you are getting the source file from. According to
> https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/file/tip/src/dev/get-
> involved.en.html#l67 it doesn't seem to be the same version.
>
> Did you use https://hg.mozilla.org/SeaMonkey/seamonkey-project-org ?
>
> Whilst you are here could you remove the extra space from the line above?
>
> f=me for the moment as need new patch against correct source.
Yea, I have used that url, to clone the project. I don't know why the version mis-match occured. I think I missed the rebase command, before making the patch.
I will remove the extra space above that line.
Comment 13•8 years ago
|
||
@Ian Neal
Could you tell me why the current patch doesn't works?
Comment 14•8 years ago
|
||
(In reply to Mayank Chauhan from comment #13)
> @Ian Neal
> Could you tell me why the current patch doesn't works?
It looks like you did not back out your first patch, so the second patch was based off code including your first patch.
Reporter | ||
Comment 15•8 years ago
|
||
@Mayank Chauhan
It seems Ian's explication was not useful for you?
Comment 16•8 years ago
|
||
If you are using mercurial queues, you can use qfold to fold two patches together.
Assignee | ||
Comment 17•8 years ago
|
||
Attachment #8827974 -
Flags: review?(jh)
Attachment #8827974 -
Flags: feedback+
Assignee | ||
Comment 18•8 years ago
|
||
Ignore the previous patch. That was a mistake.
Please review this and let me know. :)
Attachment #8827978 -
Flags: review?(jh)
Attachment #8827978 -
Flags: feedback+
Comment 19•8 years ago
|
||
Comment on attachment 8827974 [details] [diff] [review]
V1.patch
Sorry but I'm not doing reviews anymore.
Attachment #8827974 -
Flags: review?(jh)
Updated•8 years ago
|
Attachment #8827978 -
Flags: review?(jh)
Assignee | ||
Comment 20•8 years ago
|
||
Comment on attachment 8827978 [details] [diff] [review]
Proposed Patch
Proposed Patch
Attachment #8827978 -
Flags: feedback+ → review?(kairo)
Comment 21•8 years ago
|
||
Comment on attachment 8827978 [details] [diff] [review]
Proposed Patch
Looks good!
Attachment #8827978 -
Flags: review?(kairo) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: mctyson1795 → georgeveneeldogga
Keywords: checkin-needed
Comment 22•8 years ago
|
||
Pushed to the SeaMonkey website repository:
> https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/bff6722f1761290322832ce642eea5dad8988f5c
Added patch author name to the changeset/patch
Updated•7 years ago
|
Product: Websites → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•