David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Description • 8 years ago

These are all pretty consistent on TBPL.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 1 • 8 years ago

nsThreadManager::Init (from XPCOM initialization) was racing with the link thread trying to post a connected message. The result was, NS_DispatchToMainThread sometimes didn't see a main thread, and leaked the runnable.

This patch uses the same fix as ContentChild: just initialize nsThreadManager manually before calling Open() on the top-level actor.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 2 • 8 years ago

Two bugs here. First, VsyncBridgeParent was never assigned to anything so the shutdown call would never happen. Second, the shutdown implementation could access CompositorThreadHolder after it was shut down. This refactors the Shutdown function so that can't happen.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 3 • 8 years ago

nsAppShell expects XPCOM to still exist when we finally return out of the event loop, otherwise it leaks stuff. This moves XPCOM shutdown to GPUParent::CleanUp, which mirrors what ContentChild does.

	Pulsebot
	Comment 4 • 8 years ago

Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f781d8fa1cf3
Ensure nsThreadManager is started before IPC in the GPU process. (bug 1308398 part 1, r=billm)
https://hg.mozilla.org/integration/mozilla-inbound/rev/7030c3219a1e
Fix VsyncBridgeParent leaking on GPU process shutdown. (bug 1308398 part 2, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b3c7e78cfd
Move GPU process XPCOM shutdown to ProcessChild::CleanUp. (bug 1308398 part 3, r=billm)

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f781d8fa1cf3
https://hg.mozilla.org/mozilla-central/rev/7030c3219a1e
https://hg.mozilla.org/mozilla-central/rev/b4b3c7e78cfd