Closed
Bug 1308761
Opened 8 years ago
Closed 8 years ago
Re-enable non-Flash plugins for ESR52
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Core Graveyard
Plug-ins
Tracking
(firefox-esr45 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox-esr5252+ verified, firefox53 unaffected, firefox54 unaffected)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox-esr52 | 52+ | verified |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
jimm
:
review+
jcristau
:
approval-mozilla-esr52+
|
Details |
In release 52 we've disabled all plugins except Flash. For ESR 52 we want to leave these other plugins on, so we need to flip this pref on the ESR-specific branch. I'm filing this separately so that it can have good tracking flags for that change.
plugin.load_flash_only needs to be false.
Assignee | ||
Comment 1•8 years ago
|
||
There is not an ESR52 tracking flag yet, so to keep this on relman radar I'm going to mark it for 52.
status-firefox52:
--- → affected
tracking-firefox52:
--- → +
Comment 2•8 years ago
|
||
If you are going to turn off load_flash_only, we would need to backout the patch in bug 846566 as well. Could you do that at the same time?
Assignee | ||
Comment 3•8 years ago
|
||
I would suggest backing out 846566 until 53. I really don't want to compound risk for ESR52.
Comment 4•8 years ago
|
||
Marking this as blocking for 52 so it doesn't get missed.
Updated•8 years ago
|
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox-esr45:
--- → unaffected
Priority: -- → P1
Comment 5•8 years ago
|
||
Gerry, when will we have status-firefox-esr52 and tracking-firefox-esr52 flag ? With that we can correct the tracking here and leave FF52 as it was.
Flags: needinfo?(gchang)
Comment 6•8 years ago
|
||
Moving tracking to new esr52 flags.
status-firefox-esr52:
--- → affected
tracking-firefox52:
blocking → ---
tracking-firefox-esr52:
--- → 52+
Flags: needinfo?(gchang)
Comment 7•8 years ago
|
||
Can we have a patch made and nominated for the esr52 branch some time soon?
Comment 8•8 years ago
|
||
Benjamin, can you please post a patch to set the "plugin.load_flash_only" pref on ESR52 or suggest someone else we can ask?
status-firefox54:
--- → unaffected
Flags: needinfo?(benjamin)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•8 years ago
|
||
This is a patch against beta, because I presume there isn't a separate ESR branch yet.
We've already done QA testing that this pref works, but I think we should do a release QA pass on candidate ESR builds to make sure:
1) Java and silverlight show up in the addons manager
2) The browser uses them when appropriate
3) The "some plugins may be missing" notice is not present in the addon manager. It *will* be present in about:plugins, but we've decided that's ok.
Assignee: nobody → benjamin
Flags: needinfo?(benjamin)
Comment 11•8 years ago
|
||
An ESR52 branch now exists. It is being kept in sync with Beta 52 commits, but is not running CI tests.
https://hg.mozilla.org/releases/mozilla-esr52/
Depends on: 1334535
Comment 12•8 years ago
|
||
mozreview-review |
Comment on attachment 8837677 [details]
Bug 1308761 - Re-enable non-Flash plugins for ESR52,
https://reviewboard.mozilla.org/r/112736/#review114640
Attachment #8837677 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 13•8 years ago
|
||
What is supposed to happen next with this bug? Do we wait until RC to branch ESR from the mainline release?
Flags: needinfo?(jcristau)
Comment 14•8 years ago
|
||
The ESR52 branch is already alive. Go ahead and request approval.
Flags: needinfo?(jcristau)
Assignee | ||
Updated•8 years ago
|
Attachment #8837677 -
Flags: approval-mozilla-esr52?
Comment 15•8 years ago
|
||
Comment on attachment 8837677 [details]
Bug 1308761 - Re-enable non-Flash plugins for ESR52,
thanks Benjamin. re-enable non-flash plugins in the esr52 branch.
Attachment #8837677 -
Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Comment 16•8 years ago
|
||
Andrei, once it landed and the build is over ( http://archive.mozilla.org/pub/firefox/tinderbox-builds/ )
could you verify this?
Thanks
Flags: qe-verify+
Flags: needinfo?(andrei.vaida)
Comment 17•8 years ago
|
||
bugherder uplift |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 18•8 years ago
|
||
Verified fixed on 52.0.0esr-build4 using: Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.3. Non-Flash plug-ins can be enabled on 52esr and they work as intended.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(andrei.vaida)
Comment 19•8 years ago
|
||
Merci beaucoup! Have a great week end!
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•